Re: [01/32] Add function_abi.{h,cc}

2019-10-02 Thread Richard Sandiford
Bernd Edlinger writes: > Hi, > > I am currently trying to implement -Wshadow=local, and > this patch triggers a build-failure with -Wshadow=local > since i is a parameter that is the regno. > But it is also used as loop variable, > so I think this introduces probably a bug: > >> @@ -728,7 +731,11

Re: [01/32] Add function_abi.{h,cc}

2019-10-01 Thread Bernd Edlinger
Hi, I am currently trying to implement -Wshadow=local, and this patch triggers a build-failure with -Wshadow=local since i is a parameter that is the regno. But it is also used as loop variable, so I think this introduces probably a bug: > @@ -728,7 +731,11 @@ globalize_reg (tree decl, int i) >

Re: [01/32] Add function_abi.{h,cc}

2019-09-30 Thread Jeff Law
On 9/30/19 3:19 AM, Richard Sandiford wrote: > Hi Jeff, > > Thanks as always for the reviews :-) > > Jeff Law writes: >> On 9/11/19 1:03 PM, Richard Sandiford wrote: >>> This patch adds new structures and functions for handling >>> multiple ABIs in a translation unit. The structures are: >>> >>

Re: [01/32] Add function_abi.{h,cc}

2019-09-30 Thread Richard Sandiford
Hi Jeff, Thanks as always for the reviews :-) Jeff Law writes: > On 9/11/19 1:03 PM, Richard Sandiford wrote: >> This patch adds new structures and functions for handling >> multiple ABIs in a translation unit. The structures are: >> >> - predefined_function_abi: describes a static, predefined

Re: [01/32] Add function_abi.{h,cc}

2019-09-29 Thread Jeff Law
On 9/11/19 1:03 PM, Richard Sandiford wrote: > This patch adds new structures and functions for handling > multiple ABIs in a translation unit. The structures are: > > - predefined_function_abi: describes a static, predefined ABI > - function_abi: describes either a predefined ABI or a local >