On Sep 6, 2013, at 8:21 AM, Andrew MacLeod wrote:
> these would be really good to identify and fix, if possible.
> Do you know of any of the top of your head?
Sure, they are easy to find. See below. I'll note one more use of fixing
these. clang is adding modules to get compilation speed. Mo
On Fri, Sep 6, 2013 at 4:14 AM, Mike Stump wrote:
> On Sep 5, 2013, at 11:54 PM, Richard Biener
> wrote:
>> Most of the GCC headerfiles do not include all their required headers but
>> rely on .c files doing that (in the appropriate order). I somehow like
>> that though I cannot explain why ;)
On Fri, Sep 6, 2013 at 5:21 PM, Andrew MacLeod wrote:
>> hackery in some headers will suddenly break (that is, change outcome)
>> if you include for example
>> tm.h before or after it.
>>
> these would be really good to identify and fix, if possible. (surely they
> can be fixed.. :-)if they ca
On Fri, 6 Sep 2013, Richard Biener wrote:
> But yes, making all dependencies explicit puts #includes where they
> belong and shows where header refactoring would make sense. It also
> removes weird includes from .c files that are only necessary to make
> included required headers not break.
O
On 09/05/2013 08:26 PM, Joseph S. Myers wrote:
On Thu, 5 Sep 2013, Andrew MacLeod wrote:
Or are you suggesting that coretypes.h is a file we can assume is available?
Every .c file should start with includes of config.h, system.h and
coretypes.h, in that order, so all other headers can assume t
On 09/06/2013 04:19 AM, Richard Biener wrote:
On Fri, Sep 6, 2013 at 10:14 AM, Mike Stump wrote:
On Sep 5, 2013, at 11:54 PM, Richard Biener wrote:
Most of the GCC headerfiles do not include all their required headers but
rely on .c files doing that (in the appropriate order). I somehow like
On 09/06/2013 09:09 AM, Michael Matz wrote:
Hi,
On Thu, 5 Sep 2013, Andrew MacLeod wrote:
1 - I think we ought to split out the data structures from gimple.h into
gimple-core.h, like we did with tree.h
Why?
For the seam reason we split tree.h. The new gimple mechanism needs to
coexist with
Hi,
On Thu, 5 Sep 2013, Andrew MacLeod wrote:
> 1 - I think we ought to split out the data structures from gimple.h into
> gimple-core.h, like we did with tree.h
Why?
> gimple.h. That won't really affect my work. I think it probably ought to be
> done for clarity eventually.gimple.h wou
On Fri, Sep 6, 2013 at 10:14 AM, Mike Stump wrote:
> On Sep 5, 2013, at 11:54 PM, Richard Biener
> wrote:
>> Most of the GCC headerfiles do not include all their required headers but
>> rely on .c files doing that (in the appropriate order). I somehow like
>> that though I cannot explain why ;)
On Sep 5, 2013, at 11:54 PM, Richard Biener wrote:
> Most of the GCC headerfiles do not include all their required headers but
> rely on .c files doing that (in the appropriate order). I somehow like
> that though I cannot explain why ;)
Very old school. I can explain why I don't like it, but I
On Thu, Sep 5, 2013 at 5:47 PM, Andrew MacLeod wrote:
> On 09/05/2013 09:08 AM, Richard Biener wrote:
>>
>> On Thu, Sep 5, 2013 at 2:57 PM, Andrew MacLeod
>> wrote:
>>>
>>> Now that tree.h is split in two, there are some follow up things that
>>> will
>>> facilitate the deforestation of gimple.
On Thu, Sep 5, 2013 at 11:53 PM, Steven Bosscher wrote:
> On Thu, Sep 5, 2013 at 5:47 PM, Andrew MacLeod wrote:
>> ok, so to dwell on header file cleanup. When creating new header files for
>> say, tree-ssa-ter.h, what other include files should we make assumptions
>> have already been include
On Thu, 5 Sep 2013, Andrew MacLeod wrote:
> Or are you suggesting that coretypes.h is a file we can assume is available?
Every .c file should start with includes of config.h, system.h and
coretypes.h, in that order, so all other headers can assume they have been
included.
(In principle I think
On 09/05/2013 06:38 PM, Steven Bosscher wrote:
On Fri, Sep 6, 2013 at 12:22 AM, Andrew MacLeod wrote:
Or are you suggesting that coretypes.h is a file we can assume is available?
that seems like a bit of a slippery slope, but we could pick a few. I
prefer it be explicit myself.
coretypes.h is
On Fri, Sep 6, 2013 at 12:22 AM, Andrew MacLeod wrote:
> Or are you suggesting that coretypes.h is a file we can assume is available?
> that seems like a bit of a slippery slope, but we could pick a few. I
> prefer it be explicit myself.
coretypes.h is available. Why do you think that's a slipper
On 09/05/2013 05:53 PM, Steven Bosscher wrote:
On Thu, Sep 5, 2013 at 5:47 PM, Andrew MacLeod wrote:
ok, so to dwell on header file cleanup. When creating new header files for
say, tree-ssa-ter.h, what other include files should we make assumptions
have already been included... or should we
On Thu, Sep 5, 2013 at 5:47 PM, Andrew MacLeod wrote:
> ok, so to dwell on header file cleanup. When creating new header files for
> say, tree-ssa-ter.h, what other include files should we make assumptions
> have already been included... or should we make none?
> For instance, the header files
On 09/05/2013 09:08 AM, Richard Biener wrote:
On Thu, Sep 5, 2013 at 2:57 PM, Andrew MacLeod wrote:
Now that tree.h is split in two, there are some follow up things that will
facilitate the deforestation of gimple. I've also thrown in a couple of
structuring issues for good measure.
What are
On 09/05/2013 09:08 AM, Richard Biener wrote:
On Thu, Sep 5, 2013 at 2:57 PM, Andrew MacLeod wrote:
Now that tree.h is split in two, there are some follow up things that will
facilitate the deforestation of gimple. I've also thrown in a couple of
structuring issues for good measure.
What are
On Thu, Sep 5, 2013 at 2:57 PM, Andrew MacLeod wrote:
> Now that tree.h is split in two, there are some follow up things that will
> facilitate the deforestation of gimple. I've also thrown in a couple of
> structuring issues for good measure.
>
> What are your thoughts on these subjects?
Jumpin
Now that tree.h is split in two, there are some follow up things that
will facilitate the deforestation of gimple. I've also thrown in a
couple of structuring issues for good measure.
What are your thoughts on these subjects?
1 - I think we ought to split out the data structures from gimple
21 matches
Mail list logo
