Re: RFC: fix std::unique_ptr pretty-printer

2012-08-15 Thread Tom Tromey
> "Jonathan" == Jonathan Wakely writes: Jonathan> I like it, please go ahead and check that in it you're happy Jonathan> with it. I did. Thanks. Tom

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-15 Thread Jonathan Wakely
On 14 August 2012 15:44, Tom Tromey wrote: >> "Jonathan" == Jonathan Wakely writes: > > Jonathan> I prefer it as unique_ptr but I'm probably not your typical > Jonathan> user of the pretty printers, so if anyone else has an opinion please > Jonathan> share it. > > I prefer it too. Here's the

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-14 Thread Tom Tromey
> "Jonathan" == Jonathan Wakely writes: Jonathan> I prefer it as unique_ptr but I'm probably not your typical Jonathan> user of the pretty printers, so if anyone else has an opinion please Jonathan> share it. I prefer it too. Here's the updated patch. Let me know what you think. Tom 2012

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-13 Thread Jonathan Wakely
On 13 August 2012 14:31, Tom Tromey wrote: >> "Jonathan" == Jonathan Wakely writes: > >>> $11 = std::unique_ptr containing (datum *) 0x6067d0 > > Jonathan> It's inconsistent with the other printers in that it prints > Jonathan> the stored type, unlike e.g. std::vector which just says > Jonatha

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-13 Thread Tom Tromey
> "Jonathan" == Jonathan Wakely writes: >> $11 = std::unique_ptr containing (datum *) 0x6067d0 Jonathan> It's inconsistent with the other printers in that it prints Jonathan> the stored type, unlike e.g. std::vector which just says Jonathan> "std::vector of length ..." but I think that's an

Re: RFC: fix std::unique_ptr pretty-printer

2012-08-10 Thread Jonathan Wakely
On 10 August 2012 20:49, Tom Tromey wrote: > A user reported on irc that the std::unique_ptr pretty-printer yields > bad results. For example: > > (gdb) p uptr > $1 = std::tuple containing = { > [1] = , > [2] = { > > = {}, } > } > > This omits the actual pointer and prints some useless stu

RFC: fix std::unique_ptr pretty-printer

2012-08-10 Thread Tom Tromey
A user reported on irc that the std::unique_ptr pretty-printer yields bad results. For example: (gdb) p uptr $1 = std::tuple containing = { [1] = , [2] = { > = {}, } } This omits the actual pointer and prints some useless stuff instead. This patch fixes the printer and adds a test. The