Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-08-25 Thread Tom Tromey
Tom> Any comments on this? Tom> I'd like to get it in; Phil found a bug in the std::tuple printer, and Tom> it would be nice to put in a test case along with the fix. Benjamin> Hey Tom (and Phil!). Benjamin> Sorry for the delay: this looks fine. Please put it in on trunk and Benjamin> enjoy your

Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-08-24 Thread Benjamin Kosnik
> Any comments on this? > > I'd like to get it in; Phil found a bug in the std::tuple printer, and > it would be nice to put in a test case along with the fix. Hey Tom (and Phil!). Sorry for the delay: this looks fine. Please put it in on trunk and enjoy your vacation! -benjamin

Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-08-18 Thread Tom Tromey
> "Tom" == Tom Tromey writes: Tom> I'm finally getting back to this. Tom> This patch adds test suite support for the libstdc++ pretty-printers. Any comments on this? I'd like to get it in; Phil found a bug in the std::tuple printer, and it would be nice to put in a test case along with the

Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-08-03 Thread Tom Tromey
I'm finally getting back to this. This patch adds test suite support for the libstdc++ pretty-printers. These tests require a new gdb, so following Mike Stump's advice and the consensus of the libstdc++ list, we now check for an appropriate gdb feature before deciding whether to run the tests. I

Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-03-14 Thread Mike Stump
On Mar 14, 2011, at 1:33 PM, Tom Tromey wrote: > These new tests require a very new gdb in order to fully pass. In > particular these tests pointed out some buglets that are only fixed in > CVS, not in any release. > > > Trying to dynamically adjust the tests for the gdb version looks like a > p

Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-03-14 Thread Benjamin Kosnik
> Trying to dynamically adjust the tests for the gdb version looks like > a pain. > > Maybe I could change the tests to check the gdb version and xfail the > tests for gdb < 7.3. Would that be ok? Yeah. > Or I could leave it as-is, but I assume that nobody wants to see new > FAILs. Right. Un

Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-03-14 Thread Jonathan Wakely
On 14 March 2011 20:33, Tom Tromey wrote: > Tom> * testsuite/libstdc++-pp/simple.cc: New file. > Tom> * testsuite/lib/gdb-test.exp: New file. > Tom> * testsuite/libstdc++-pp/pp.exp: New file. > > Benjamin> feel free to spell out prettyprinters instead of using pp, if you > want > Benjamin> to make

Re: RFC: add a testsuite for libstdc++ pretty-printers

2011-03-14 Thread Tom Tromey
Tom> * testsuite/libstdc++-pp/simple.cc: New file. Tom> * testsuite/lib/gdb-test.exp: New file. Tom> * testsuite/libstdc++-pp/pp.exp: New file. Benjamin> feel free to spell out prettyprinters instead of using pp, if you want Benjamin> to make it very obvious what is going on in this directory. Be