Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-11-05 Thread Bernd Schmidt
On 10/31/2012 01:12 PM, Richard Sandiford wrote: > OK with those changes for the rtl bits. Can't approve the generator > stuff though. That's also OK. Bernd

Re: Fwd/Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-11-04 Thread Alexandre Oliva
On Nov 1, 2012, Joern Rennecke wrote: > Quoting Richard Sandiford : >> OK with those changes for the rtl bits. Can't approve the generator >> stuff though. > Can you build machinery maintainers also review gen* and *.def patches, > of this patch ( http://gcc.gnu.org/ml/gcc-patches/2012-10/msg0

Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-11-04 Thread Joern Rennecke
Quoting Richard Sandiford : OK with those changes for the rtl bits. Can't approve the generator stuff though. It appears we are momentarily short of reviewers for the generator files. Till someone who feels he is competent to review the generator file patches finds the time to review them, c

Fwd/Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-11-01 Thread Joern Rennecke
Quoting Richard Sandiford : OK with those changes for the rtl bits. Can't approve the generator stuff though. Can you build machinery maintainers also review gen* and *.def patches, of this patch ( http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02897.html ). or are you strictly limited to *.in

Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-10-31 Thread Richard Sandiford
Joern Rennecke writes: > Quoting Richard Sandiford : > >> I can't approve the whole thing of course, but I like the idea. >> However... >> >> Joern Rennecke writes: >>> +@deftypevr {Target Hook} bool TARGET_HAVE_CC0 >>> +@deftypevrx {Target Hook} {bool} TARGET_AUTO_INC_DEC >>> +@deftypevrx {Targe

Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-10-31 Thread Joern Rennecke
Quoting Richard Sandiford : I can't approve the whole thing of course, but I like the idea. However... Joern Rennecke writes: +@deftypevr {Target Hook} bool TARGET_HAVE_CC0 +@deftypevrx {Target Hook} {bool} TARGET_AUTO_INC_DEC +@deftypevrx {Target Hook} {bool} TARGET_STACK_REGS +@deftypevrx {

Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-10-30 Thread Richard Sandiford
I can't approve the whole thing of course, but I like the idea. However... Joern Rennecke writes: > +@deftypevr {Target Hook} bool TARGET_HAVE_CC0 > +@deftypevrx {Target Hook} {bool} TARGET_AUTO_INC_DEC > +@deftypevrx {Target Hook} {bool} TARGET_STACK_REGS > +@deftypevrx {Target Hook} {bool} TARG

Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-10-28 Thread Joern Rennecke
Quoting Andreas Schwab : +These flags are automatically generated; you should not override them in tm.c: Typo: s/:$/./, also @file{tm.c}. Thanks. I have re-bootstrapped the amended patch on i686-pc-linux-gnu. 2012-10-28 Joern Rennecke * doc/md.texi (Defining Attributes): Docu

Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-10-28 Thread Andreas Schwab
Joern Rennecke writes: > Index: gcc/doc/tm.texi > === > --- gcc/doc/tm.texi (revision 192840) > +++ gcc/doc/tm.texi (working copy) > @@ -11333,3 +11333,11 @@ @deftypefn {Target Hook} {unsigned HOST_ > @deftypevr {Target Hook} {u

Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-10-27 Thread Joern Rennecke
With the lra branch merged, I had to update the patch, because of new uses of HAVE_ATTTR_enabled. While looking at the conflicts, I also found that it was often hard to tell if macros were used for performance reasons, or just because there was no other interface available. lra itself is probably

RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-10-21 Thread Joern Rennecke
As discussed on the gcc mailing list ("RFD: HAVE_* pattern flags"), we would like to have fewer #ifdefs littered throughout our functions. And in order to get there, we first need flags with values that are suitable for the C / C++ parsers, i.e. values 1 or 0 instead of defined or not. This patch