Re: RFA: Use gen_int_mode in plus_constant

2013-05-22 Thread Richard Biener
On Wed, May 22, 2013 at 11:02 AM, Richard Sandiford wrote: > Andreas Krebbel writes: >> On 21/05/13 11:26, Richard Sandiford wrote: >>> gcc/ >>> * recog.c (offsettable_address_addr_space_p): Fix calculation of >>> address mode. Move pointer mode initialization to the same place. >> >>

Re: RFA: Use gen_int_mode in plus_constant

2013-05-22 Thread Richard Sandiford
Andreas Krebbel writes: > On 21/05/13 11:26, Richard Sandiford wrote: >> gcc/ >> * recog.c (offsettable_address_addr_space_p): Fix calculation of >> address mode. Move pointer mode initialization to the same place. > > Thanks! This fixed the failure (and others). Bootstrapped on s390x -

Re: RFA: Use gen_int_mode in plus_constant

2013-05-21 Thread Andreas Krebbel
On 21/05/13 11:26, Richard Sandiford wrote: > Andreas Krebbel writes: >> On 21/05/13 10:39, Richard Sandiford wrote: >>> Andreas Krebbel writes: On 30/04/13 16:56, Richard Sandiford wrote: > This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out > in the wide-int revi

Re: RFA: Use gen_int_mode in plus_constant

2013-05-21 Thread Richard Sandiford
Andreas Krebbel writes: > On 21/05/13 10:39, Richard Sandiford wrote: >> Andreas Krebbel writes: >>> On 30/04/13 16:56, Richard Sandiford wrote: This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out in the wide-int review. It also passes "mode" rather than "VOIDmode" >

Re: RFA: Use gen_int_mode in plus_constant

2013-05-21 Thread Andreas Krebbel
On 21/05/13 10:39, Richard Sandiford wrote: > Andreas Krebbel writes: >> On 30/04/13 16:56, Richard Sandiford wrote: >>> This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out >>> in the wide-int review. It also passes "mode" rather than "VOIDmode" >>> to immed_double_int_const.

Re: RFA: Use gen_int_mode in plus_constant

2013-05-21 Thread Richard Sandiford
Andreas Krebbel writes: > On 30/04/13 16:56, Richard Sandiford wrote: >> This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out >> in the wide-int review. It also passes "mode" rather than "VOIDmode" >> to immed_double_int_const. (As discussed in that thread, the latter >> change

Re: RFA: Use gen_int_mode in plus_constant

2013-05-21 Thread Andreas Krebbel
On 30/04/13 16:56, Richard Sandiford wrote: > This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out > in the wide-int review. It also passes "mode" rather than "VOIDmode" > to immed_double_int_const. (As discussed in that thread, the latter > change shouldn't make any difference

Re: RFA: Use gen_int_mode in plus_constant

2013-04-30 Thread Richard Biener
Richard Sandiford wrote: >This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out >in the wide-int review. It also passes "mode" rather than "VOIDmode" >to immed_double_int_const. (As discussed in that thread, the latter >change shouldn't make any difference in practice, but is s

RFA: Use gen_int_mode in plus_constant

2013-04-30 Thread Richard Sandiford
This patch fixes out the GEN_INT/gen_int_mode that Richard pointed out in the wide-int review. It also passes "mode" rather than "VOIDmode" to immed_double_int_const. (As discussed in that thread, the latter change shouldn't make any difference in practice, but is still more correct in principle.