Ramana Radhakrishnan writes:
> On Sun, Oct 7, 2012 at 8:56 AM, Richard Sandiford
> wrote:
>> Eric Botcazou writes:
I think modelling it as a TRUNCATE operation is correct for
!TRULY_NOOP_TRUNCATION (it's the bug that Andrew pointed out).
And we shouldn't generate an actual TRUNCAT
On Sun, Oct 7, 2012 at 8:56 AM, Richard Sandiford
wrote:
> Eric Botcazou writes:
>>> I think modelling it as a TRUNCATE operation is correct for
>>> !TRULY_NOOP_TRUNCATION (it's the bug that Andrew pointed out).
>>> And we shouldn't generate an actual TRUNCATE rtx for
>>> TRULY_NOOP_TRUNCATION (t
> Yeah, in hindsight, the patch was definitely lacking commentary.
> How about the patch below? It also fixes the partial int case
> and gets rid of the errant NOT hunk. Tested in the same way as before.
>
> Richard
>
>
> gcc/
> * machmode.h (GET_MODE_UNIT_PRECISION): New macro.
>
Eric Botcazou writes:
>> I think modelling it as a TRUNCATE operation is correct for
>> !TRULY_NOOP_TRUNCATION (it's the bug that Andrew pointed out).
>> And we shouldn't generate an actual TRUNCATE rtx for
>> TRULY_NOOP_TRUNCATION (the thing about making
>> simplify_gen_unary (TRUNCATE, ...) no w
> I think modelling it as a TRUNCATE operation is correct for
> !TRULY_NOOP_TRUNCATION (it's the bug that Andrew pointed out).
> And we shouldn't generate an actual TRUNCATE rtx for
> TRULY_NOOP_TRUNCATION (the thing about making
> simplify_gen_unary (TRUNCATE, ...) no worse than simplify_gen_subre
Thanks for the review.
Eric Botcazou writes:
>> Tested on x86_64-linux-gnu, mipsisa32-elf and mipsisa64-elf. Also tested
>> by making sure that there were no code differences for a set of gcc .ii
>> files on gcc20 (-O2 -march=native). OK to install?
>
> Are you sure that generating TRUNCATEs ou
> Tested on x86_64-linux-gnu, mipsisa32-elf and mipsisa64-elf. Also tested
> by making sure that there were no code differences for a set of gcc .ii
> files on gcc20 (-O2 -march=native). OK to install?
Are you sure that generating TRUNCATEs out of nowhere in simplify_subreg is
always correct?
[cc:ing sh, spu and tilegx maintainers]
Richard Sandiford writes:
> Andrew Pinski writes:
>> On Thu, Sep 27, 2012 at 11:13 AM, Uros Bizjak wrote:
>>> 2012-09-27 Uros Bizjak
>>>
>>> PR rtl-optimization/54457
>>> * simplify-rtx.c (simplify_subreg):
>>> Simplify (subreg:
