Re: RFA: Improve tree-ssa-sink block selection

2011-10-19 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/18/11 01:44, Paolo Bonzini wrote: > On 10/18/2011 07:10 AM, Jeff Law wrote: >> --- 467,475 if (gimple_code (use) != GIMPLE_PHI) { sinkbb = >> gimple_bb (use); ! sinkbb = select_best_block (frombb, >> gimple_bb (use), stmt); >> >> !

Re: RFA: Improve tree-ssa-sink block selection

2011-10-18 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/18/11 01:44, Paolo Bonzini wrote: > On 10/18/2011 07:10 AM, Jeff Law wrote: >> --- 467,475 if (gimple_code (use) != GIMPLE_PHI) { sinkbb = >> gimple_bb (use); ! sinkbb = select_best_block (frombb, >> gimple_bb (use), stmt); >> >> !

Re: RFA: Improve tree-ssa-sink block selection

2011-10-18 Thread Paolo Bonzini
On 10/18/2011 07:10 AM, Jeff Law wrote: --- 467,475 if (gimple_code (use) != GIMPLE_PHI) { sinkbb = gimple_bb (use); ! sinkbb = select_best_block (frombb, gimple_bb (use), stmt); ! if (sinkbb == frombb) return false; *togsi =

RFA: Improve tree-ssa-sink block selection

2011-10-17 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 tree-ssa-sink.c could benefit from a little TLC in its code to select statement's final location. For those not familiar with tree-ssa-sink, it attempts to sink statements down in the CFG to points where they're less likely to execute. Ideally we mo