Re: RFA: Fix uninitialized memory use in sched_macro_fuse_insns

2019-04-09 Thread Jeff Law
On 4/5/19 8:47 AM, Richard Sandiford wrote: > Joern Rennecke writes: >> On Fri, 5 Apr 2019 at 11:07, Richard Sandiford >> wrote: >> >> 2019-04-04 Joern Rennecke * sched-deps.c (sched_macro_fuse_insns): Check return value of targetm.fixed_condition_code_regs. >>>

Re: RFA: Fix uninitialized memory use in sched_macro_fuse_insns

2019-04-05 Thread Richard Sandiford
Joern Rennecke writes: > On Fri, 5 Apr 2019 at 11:07, Richard Sandiford > wrote: > > >> > 2019-04-04 Joern Rennecke >> > >> > * sched-deps.c (sched_macro_fuse_insns): Check return value of >> > targetm.fixed_condition_code_regs. >> >> OK, thanks. > > Thanks for the review. > > Is t

Re: RFA: Fix uninitialized memory use in sched_macro_fuse_insns

2019-04-05 Thread Joern Rennecke
On Fri, 5 Apr 2019 at 11:07, Richard Sandiford wrote: > > 2019-04-04 Joern Rennecke > > > > * sched-deps.c (sched_macro_fuse_insns): Check return value of > > targetm.fixed_condition_code_regs. > > OK, thanks. Thanks for the review. Is that OK restricted to delayed applying once

Re: RFA: Fix uninitialized memory use in sched_macro_fuse_insns

2019-04-05 Thread Richard Sandiford
Joern Rennecke writes: > sched_macro_fuse_insns uses the value in condreg1 without > checking the return value of targetm.fixed_condition_code_regs. As > this variables > is not initialized anywhere, this leads to constructing cc_reg_1 with > an undefined value, > and then using that in reg_refer

RFA: Fix uninitialized memory use in sched_macro_fuse_insns

2019-04-04 Thread Joern Rennecke
sched_macro_fuse_insns uses the value in condreg1 without checking the return value of targetm.fixed_condition_code_regs. As this variables is not initialized anywhere, this leads to constructing cc_reg_1 with an undefined value, and then using that in reg_referenced_p, if TARGET_FIXED_CONDITION_C