Re: RFA: Fix mode checks for possibly-constant predicates

2015-06-03 Thread Richard Sandiford
Richard Sandiford writes: > Richard Henderson writes: >> On 05/29/2015 10:23 AM, Richard Sandiford wrote: >>> + /* Check whether the predicate accepts const scalar ints (which always >>> + have a stored mode of VOIDmode, but logically have a real mode) >>> + and whether it matches anythi

Re: RFA: Fix mode checks for possibly-constant predicates

2015-06-02 Thread Richard Sandiford
Richard Henderson writes: > On 05/29/2015 10:23 AM, Richard Sandiford wrote: >> + /* Check whether the predicate accepts const scalar ints (which always >> + have a stored mode of VOIDmode, but logically have a real mode) >> + and whether it matches anything besides const scalar ints. */

Re: RFA: Fix mode checks for possibly-constant predicates

2015-05-29 Thread Richard Henderson
On 05/29/2015 10:23 AM, Richard Sandiford wrote: > + /* Check whether the predicate accepts const scalar ints (which always > + have a stored mode of VOIDmode, but logically have a real mode) > + and whether it matches anything besides const scalar ints. */ > + bool matches_const_scalar_

RFA: Fix mode checks for possibly-constant predicates

2015-05-29 Thread Richard Sandiford
genrecog relies on a predicate foo_operand (op, mode) checking that OP really does have mode MODE, with VOIDmode acting as a wildcard. This was true even with the old genrecog, but as Andreas found on s390x, new genrecog is being a bit more aggressive about it. The problem is that at the moment,