Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-08-10 Thread Hans-Peter Nilsson via Gcc-patches
> From: Segher Boessenkool > Date: Fri, 17 Jul 2020 02:05:19 +0200 > On Tue, Jul 14, 2020 at 04:33:42PM -0500, Segher Boessenkool wrote: > > > If combine only did lower-cost combinations (perhaps with > > > Richard Sandifords lower-size-when-tied suggestion), I guess > > > this wouldn't happen. 0

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-16 Thread Segher Boessenkool
On Tue, Jul 14, 2020 at 04:33:42PM -0500, Segher Boessenkool wrote: > > If combine only did lower-cost combinations (perhaps with > > Richard Sandifords lower-size-when-tied suggestion), I guess > > this wouldn't happen. 0:-) > > And we would regress (a LOT). Like this. C0 is an unmodified compi

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-14 Thread Segher Boessenkool
Hi! On Mon, Jul 13, 2020 at 07:25:37AM +0200, Hans-Peter Nilsson wrote: > > > > > TL;DR: fixing a misdetection of what is a "simple move". > > > > > > > > That is not a very correct characterisation of what this does :-) > > > > > > That's apparently where we completely disagree. :-) > > > > We

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-14 Thread Segher Boessenkool
On Mon, Jul 13, 2020 at 07:29:00AM +0200, Hans-Peter Nilsson wrote: > > From: Segher Boessenkool > > Date: Tue, 7 Jul 2020 22:50:43 +0200 > > > I'll make a simpler patch. Thanks! > > You're welcome. So, you'll take care of the updated patch > yourself? Yes. Delayed a bit, I had a lot to do f

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-12 Thread Hans-Peter Nilsson via Gcc-patches
> From: Segher Boessenkool > Date: Tue, 7 Jul 2020 22:50:43 +0200 > I'll make a simpler patch. Thanks! You're welcome. So, you'll take care of the updated patch yourself? (I'll wait a month before sending an update either way.) brgds, H-P

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-12 Thread Hans-Peter Nilsson via Gcc-patches
> From: Segher Boessenkool > Date: Tue, 7 Jul 2020 22:23:59 +0200 > Hi! > > On Tue, Jul 07, 2020 at 02:50:09AM +0200, Hans-Peter Nilsson wrote: > > > On Mon, Jul 06, 2020 at 03:11:17AM +0200, Hans-Peter Nilsson wrote: > > > > TL;DR: fixing a misdetection of what is a "simple move". > > > > > >

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-07 Thread Segher Boessenkool
Hi! On Mon, Jul 06, 2020 at 03:11:17AM +0200, Hans-Peter Nilsson wrote: > TL;DR: fixing a misdetection of what is a "simple move". As set before, this is not a fix, not a "misdetection", it is plain and simple a behaviour change. "Use single_set for is_just_move" would be a fine subject. > Rega

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-07 Thread Segher Boessenkool
Hi! On Tue, Jul 07, 2020 at 02:50:09AM +0200, Hans-Peter Nilsson wrote: > > On Mon, Jul 06, 2020 at 03:11:17AM +0200, Hans-Peter Nilsson wrote: > > > TL;DR: fixing a misdetection of what is a "simple move". > > > > That is not a very correct characterisation of what this does :-) > > That's appa

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-06 Thread Hans-Peter Nilsson via Gcc-patches
> From: Segher Boessenkool > Date: Tue, 7 Jul 2020 01:42:47 +0200 (Regarding is_just_move in combine.c.) > But it is *not* supposed to be the same as single_set. > > > I checked the original commit, c4c5ad1d6d1e1e a.k.a r263067 and > > it seems parallels-as-sets were just overlooked and that th

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-06 Thread Hans-Peter Nilsson via Gcc-patches
> From: Segher Boessenkool > Date: Tue, 7 Jul 2020 01:42:47 +0200 TL;DR: recognize a parallel with a clobber of TARGET_FLAGS_REGNUM? > Hi! > > On Mon, Jul 06, 2020 at 03:11:17AM +0200, Hans-Peter Nilsson wrote: > > TL;DR: fixing a misdetection of what is a "simple move". > > That is not a very

Re: RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-06 Thread Segher Boessenkool
Hi! On Mon, Jul 06, 2020 at 03:11:17AM +0200, Hans-Peter Nilsson wrote: > TL;DR: fixing a misdetection of what is a "simple move". That is not a very correct characterisation of what this does :-) > Looking into performace degradation after de-cc0 for CRIS, I > noticed combine behaving badly; it

RFA: Fix combine.c combining a move and a non-move into two non-moves, PR93372

2020-07-05 Thread Hans-Peter Nilsson via Gcc-patches
TL;DR: fixing a misdetection of what is a "simple move". Looking into performace degradation after de-cc0 for CRIS, I noticed combine behaving badly; it changed a move and a right-shift into two right-shifts, where the "combined" move was not eliminated in later passes, and where the deficiency ca