Re: [committed] [testsuite] Fix fp-int-convert-timode-1.c testism.

2019-11-22 Thread Joseph Myers
On Fri, 22 Nov 2019, Tamar Christina wrote: > Hi Joseph, > > > > Or do you want me to send them separately? > > > > I think it's best to fix the test now not to have the #ifdef, then if you > > have execution failures those can be addressed separately. (If you want > > to avoid the test FAILi

Re: [committed] [testsuite] Fix fp-int-convert-timode-1.c testism.

2019-11-22 Thread Tamar Christina
Hi Joseph, > > Or do you want me to send them separately? > > I think it's best to fix the test now not to have the #ifdef, then if you > have execution failures those can be addressed separately. (If you want > to avoid the test FAILing before then, an XFAIL with a comment referencing > an o

RE: [committed] [testsuite] Fix fp-int-convert-timode-1.c testism.

2019-11-21 Thread Joseph Myers
On Thu, 21 Nov 2019, Tamar Christina wrote: > Hi Joseph, > > > FE_TONEAREST is the default rounding mode, so it would be better just to > > remove the fesetround call and include and fenv effective-target > > and -frounding-math option and let this test run for all configurations with > > int128

RE: [committed] [testsuite] Fix fp-int-convert-timode-1.c testism.

2019-11-21 Thread Tamar Christina
Hi Joseph, > FE_TONEAREST is the default rounding mode, so it would be better just to > remove the fesetround call and include and fenv effective-target > and -frounding-math option and let this test run for all configurations with > int128 support. > Hmm right, doing makes the execution of the

Re: [committed] [testsuite] Fix fp-int-convert-timode-1.c testism.

2019-11-21 Thread Joseph Myers
On Thu, 21 Nov 2019, Tamar Christina wrote: > Hi All, > > The test fp-int-convert-timode-1.c uses FE_TONEAREST without > actually checking if the target has defined it. > > Like the rest of the tests I now add a check to see if the target > has actually implemented it. FE_TONEAREST is the defau