Got you point, thanks kito and will send patch v2 after test.
Pan
-Original Message-
From: Kito Cheng
Sent: Monday, August 7, 2023 2:35 PM
To: Li, Pan2
Cc: juzhe.zh...@rivai.ai; gcc-patches ; Wang, Yanzhang
Subject: Re: RE: [PATCH v1] RISC-V: Refactor RVV frm_mode attr for rounding
uot;type" "vfalu,vfwalu,vfmul,vfdiv,vfwmul,vfdiv,vfwmul")
> > -(const_string "dyn")]
> > +(const_string "FRM_DYN")]
> >(const_string "none")))
>
> Pan
>
> -Original Message-
> From: Kito Cheng
_string "none")))
Pan
-Original Message-
From: Kito Cheng
Sent: Monday, August 7, 2023 11:27 AM
To: Li, Pan2
Cc: juzhe.zh...@rivai.ai; gcc-patches ; Wang, Yanzhang
Subject: Re: RE: [PATCH v1] RISC-V: Refactor RVV frm_mode attr for rounding
mode intrinsic
What about using
What about using similar way as vlmul?
# NOTE: diff is based on your patch.
[kitoc@hsinchu02 riscv]$ git diff
diff --git a/gcc/config/riscv/riscv-protos.h b/gcc/config/riscv/riscv-protos.h
index 33f7cb1d670..3cb5c23cb09 100644
--- a/gcc/config/riscv/riscv-protos.h
+++ b/gcc/config/riscv/riscv-pro
Sure thing, let’s wait kito’s comment for this.
Pan
From: juzhe.zh...@rivai.ai
Sent: Monday, August 7, 2023 9:31 AM
To: Li, Pan2 ; gcc-patches
Cc: Wang, Yanzhang ; kito.cheng
Subject: Re: RE: [PATCH v1] RISC-V: Refactor RVV frm_mode attr for rounding
mode intrinsic
I have no ideal. I would
I have no ideal. I would prefer kito makes decision here.
juzhe.zh...@rivai.ai
From: Li, Pan2
Date: 2023-08-07 09:22
To: juzhe.zh...@rivai.ai; gcc-patches
CC: Wang, Yanzhang; kito.cheng
Subject: RE: [PATCH v1] RISC-V: Refactor RVV frm_mode attr for rounding mode
intrinsic
We will have
e here in GCC coding style?
Pan
From: juzhe.zh...@rivai.ai
Sent: Monday, August 7, 2023 8:46 AM
To: Li, Pan2 ; gcc-patches
Cc: Li, Pan2 ; Wang, Yanzhang ;
kito.cheng
Subject: Re: [PATCH v1] RISC-V: Refactor RVV frm_mode attr for rounding mode
intrinsic
+ (set (attr "frm_mode"
+ (set (attr "frm_mode")
+ (symbol_ref "(enum attr_frm_mode) riscv_vector::get_frm_mode
(operands[8])"))])
I don't think we need "(enum attr_frm_mode)"
juzhe.zh...@rivai.ai
From: pan2.li
Date: 2023-08-06 11:36
To: gcc-patches
CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng
Subjec
