Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-23 Thread Palmer Dabbelt
bi=lp64d -c -S -o - Pan -Original Message- From: Li, Pan2 Sent: Tuesday, April 23, 2024 10:32 AM To: Patrick O'Neill ; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; rdapp@gmail.com Subject: RE: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544

Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-23 Thread Patrick O'Neill
---Original Message- From: Li, Pan2 Sent: Tuesday, April 23, 2024 10:32 AM To: Patrick O'Neill ; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; rdapp@gmail.com Subject: RE: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1 Thanks Patri

RE: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-22 Thread Li, Pan2
- From: Li, Pan2 Sent: Tuesday, April 23, 2024 10:32 AM To: Patrick O'Neill ; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; rdapp@gmail.com Subject: RE: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1 Thanks Patrick. Turn out t

RE: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-22 Thread Li, Pan2
-Original Message- From: Patrick O'Neill Sent: Tuesday, April 23, 2024 8:32 AM To: Li, Pan2 ; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; kito.ch...@gmail.com; rdapp@gmail.com Subject: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1 This pat

Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-22 Thread Patrick O'Neill
This patch in particular does not cause any more regressions. It's one of the other reverts from the weekend. Before the reverts [1]:                     |  gcc |  g++ | gfortran |     rv64gcv/  lp64d/ medlow |   48/    32 |     12/    3|   12 /    2

RE: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-22 Thread Li, Pan2
...@intel.com>; gcc-patches<mailto:gcc-patches@gcc.gnu.org> CC: juzhe.zhong<mailto:juzhe.zh...@rivai.ai>; kito.cheng<mailto:kito.ch...@gmail.com>; rdapp.gcc<mailto:rdapp....@gmail.com> Subject: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e

Re: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-22 Thread 钟居哲
I think the revert patch exposes latent bug, Li Pan will look into it. juzhe.zh...@rivai.ai From: Patrick O'Neill Date: 2024-04-23 03:55 To: pan2.li; gcc-patches CC: juzhe.zhong; kito.cheng; rdapp.gcc Subject: Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d

Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-22 Thread Patrick O'Neill
Hi Pan, I was running the testsuite for this and noticed an ICE scroll by when this patch is applied to cacc55a4c0be8d0bc7417b6a28924eadbbe428e3 for rv64gcv: FAIL: gfortran.dg/graphite/pr29832.f90   -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions  (internal

Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-22 Thread Palmer Dabbelt
On Mon, 22 Apr 2024 06:47:34 PDT (-0700), pan2...@intel.com wrote: From: Pan Li After we reverted below 2 commits, the reference to attr need some adjustment as the group_overlap is no longer available. * RISC-V: Robostify the W43, W86, W87 constraint enabled attribute * RISC-V: Rename vconstr

Re: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1

2024-04-22 Thread 钟居哲
lgtm juzhe.zh...@rivai.ai From: pan2.li Date: 2024-04-22 21:47 To: gcc-patches CC: juzhe.zhong; kito.cheng; rdapp.gcc; Pan Li Subject: [PATCH v1] RISC-V: Adjust overlap attr after revert d3544cea63d and e65aaf8efe1 From: Pan Li After we reverted below 2 commits, the reference to attr need