Re: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make-lang.in [PR119213].

2025-03-17 Thread Jakub Jelinek
On Mon, Mar 17, 2025 at 03:26:45PM -0500, Robert Dubner wrote: > > > > -Original Message- > > From: Jakub Jelinek > > Sent: Monday, March 17, 2025 16:05 > > To: Iain Sandoe > > Cc: Robert Dubner ; GCC Patches > patc...@gcc.gnu.org> > >

Re: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make-lang.in [PR119213].

2025-03-17 Thread Jakub Jelinek
On Mon, Mar 17, 2025 at 09:50:53PM +0100, Jakub Jelinek wrote: > https://www.gnu.org/prep/standards/html_node/Change-Logs.html > contains some of the reasons and something about the formatting etc. > When you repeat the same description over and over, normally one just writes > * cdf.y: Modif

RE: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make-lang.in [PR119213].

2025-03-17 Thread Robert Dubner
> -Original Message- > From: Jakub Jelinek > Sent: Monday, March 17, 2025 17:04 > To: Robert Dubner ; Iain Sandoe > ; GCC Patches > Subject: Re: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make- > lang.in [PR119213]. > > On Mon, Mar 17, 2025 at 09:5

Re: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make-lang.in [PR119213].

2025-03-17 Thread Andreas Schwab
On Mär 17 2025, Robert Dubner wrote: > I did it, reflexively, because I think that lining stuff like that up iss > easier to understand and more clear than. > > PR cobol/119213 > * Make-lang.in: Eliminate CPPFLAGS= assignment. > * cdf.y: Modify #includes that reference libgcobol.

RE: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make-lang.in [PR119213].

2025-03-17 Thread Robert Dubner
> -Original Message- > From: Jakub Jelinek > Sent: Monday, March 17, 2025 16:05 > To: Iain Sandoe > Cc: Robert Dubner ; GCC Patches patc...@gcc.gnu.org> > Subject: Re: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make- > lang.in [PR119213]. > >

Re: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make-lang.in [PR119213].

2025-03-17 Thread Iain Sandoe
Hello Robert, > On 17 Mar 2025, at 17:45, Robert Dubner wrote: > > If this is deemed OK, then we can close out PR119213 > > It compiles and runs my both check-cobol and my more comprehensive > tests on x86_64 This looks a reasonable approach to me; it has the advantage of making the shared h

Re: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make-lang.in [PR119213].

2025-03-17 Thread Jakub Jelinek
On Mon, Mar 17, 2025 at 07:57:43PM +, Iain Sandoe wrote: > > PR cobol/119213 > > * Make-lang.in: Eliminate CPPFLAGS= assignment. > > * cdf.y: Modify #includes that reference libgcobol. > > * cobol1.cc: Modify #includes that reference libgcobol. > > * except.c