RE: [PATCH] Fix mips-{mti,img}-linux-gnu boot-strap

2015-07-04 Thread Matthew Fortune
Bernd Edlinger writes: > On Sat, 4 Jul 2015 09:04:41, Richard Sandiford wrote: > > > > The final return here would also mishandle SEQUENCE PATTERNs. > > The idea was that this function would only see "real" instructions, > > so I think instead the FOR_EACH_SUBINSN should be here: > > > > static bo

RE: [PATCH] Fix mips-{mti,img}-linux-gnu boot-strap

2015-07-04 Thread Bernd Edlinger
Hi, On Sat, 4 Jul 2015 09:04:41, Richard Sandiford wrote: > > The final return here would also mishandle SEQUENCE PATTERNs. > The idea was that this function would only see "real" instructions, > so I think instead the FOR_EACH_SUBINSN should be here: > > static bool > mips_find_gp_ref (bool *cach

Re: [PATCH] Fix mips-{mti,img}-linux-gnu boot-strap

2015-07-04 Thread Richard Sandiford
Bernd Edlinger writes: > --- gcc/config/mips/mips.c.jj 2015-06-08 23:06:50.0 +0200 > +++ gcc/config/mips/mips.c2015-07-03 13:16:02.637293167 +0200 > @@ -9902,8 +9902,11 @@ mips_cfun_has_inflexible_gp_ref_p (void) > static bool > mips_insn_has_flexible_gp_ref_p (rtx_insn *insn) > { >

RE: [PATCH] Fix mips-{mti,img}-linux-gnu boot-strap

2015-07-04 Thread Matthew Fortune
Bernd Edlinger writes: > Hi,this patch fixes a regression that was triggered by commit > r225260.See > pr66747 for details.Is it OK for > trunk?ThanksBernd. Thanks Bernd. I was just reviewing this PR. I think it will probably be safer to move the fix up to the mips_find_gp_ref and consider eac