RE: [PATCH][ARM] translation: reuse string and use switch for codes

2022-03-07 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Gcc-patches bounces+kyrylo.tkachov=arm@gcc.gnu.org> On Behalf Of Martin Liška > Sent: Monday, March 7, 2022 10:22 AM > To: Christophe Lyon ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH][ARM] translation: reuse string and use switch f

Re: [PATCH][ARM] translation: reuse string and use switch for codes

2022-03-07 Thread Martin Liška
On 3/7/22 11:18, Christophe Lyon via Gcc-patches wrote: Hi! On 3/7/22 11:09, Martin Liška wrote: Hi. The patch simplifies translation strings. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. This is an arm-only patch, it's not clear if you built a cross-compiler for a

Re: [PATCH][ARM] translation: reuse string and use switch for codes

2022-03-07 Thread Christophe Lyon via Gcc-patches
Hi! On 3/7/22 11:09, Martin Liška wrote: Hi. The patch simplifies translation strings. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. This is an arm-only patch, it's not clear if you built a cross-compiler for arm, and that these regression tests passed? Ready to b

Re: [PATCH][ARM] translation: reuse string and use switch for codes

2022-03-07 Thread Martin Liška
On 3/7/22 11:12, Jakub Jelinek wrote: Will defer review to ARM maintainers, just wanted to mention some of the lines are way too long (before or after). Sure, fixed in V3. MartinFrom 34a195d905bb1719e13c2021ee475a0581b62a5b Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 7 Mar 2022 10:

Re: [PATCH][ARM] translation: reuse string and use switch for codes

2022-03-07 Thread Martin Liška
Hello. There's V2 where I fixed fact that: ARM_BUILTIN_WRORHI || fcode == ARM_BUILTIN_WRORH can have valid range on [1, 16]. Ready to be installed? Thanks, MartinFrom 879262c3a7aefd3ab9552cec881248b240f53818 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 7 Mar 2022 10:56:43 +0100 Subj

Re: [PATCH][ARM] translation: reuse string and use switch for codes

2022-03-07 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 07, 2022 at 11:09:26AM +0100, Martin Liška wrote: > gcc/ChangeLog: > > * config/arm/arm-builtins.cc (arm_expand_builtin): Reuse error > message. Will defer review to ARM maintainers, just wanted to mention some of the lines are way too long (before or after). > --- a/gcc/