Re: Propagate BB predicates in ipa-inline-analysis

2011-09-06 Thread Richard Guenther
On Mon, Sep 5, 2011 at 8:53 PM, Jan Hubicka wrote: >> Jan Hubicka wrote: >> >> > this is patch I comitted fixing ipa-inline-analysis. >> >> Thanks for fixing this! >> >> Richard Guenther wrote: >> >> > Can you open a bugreport? >> >> Sorry, I didn't see this until now.  Given that the fix is >> al

Re: Propagate BB predicates in ipa-inline-analysis

2011-09-05 Thread Jan Hubicka
> Jan Hubicka wrote: > > > this is patch I comitted fixing ipa-inline-analysis. > > Thanks for fixing this! > > Richard Guenther wrote: > > > Can you open a bugreport? > > Sorry, I didn't see this until now. Given that the fix is > already checked in (and the problem doesn't exist on any > re

Re: Propagate BB predicates in ipa-inline-analysis

2011-09-05 Thread Ulrich Weigand
Jan Hubicka wrote: > this is patch I comitted fixing ipa-inline-analysis. Thanks for fixing this! Richard Guenther wrote: > Can you open a bugreport? Sorry, I didn't see this until now. Given that the fix is already checked in (and the problem doesn't exist on any release branch), I guess we

Re: Propagate BB predicates in ipa-inline-analysis

2011-09-05 Thread Richard Guenther
On Mon, Sep 5, 2011 at 9:41 AM, Jan Hubicka wrote: > Hi, > this is patch I comitted fixing ipa-inline-analysis.  Stil I guess we should > fill in PR for missed optimization and solve the forwprop issue? I'm looking at it, it seems to be cfgcleanups bug Richard. > Honza > > Index: ChangeLog > ==

Re: Propagate BB predicates in ipa-inline-analysis

2011-09-05 Thread Jan Hubicka
Hi, this is patch I comitted fixing ipa-inline-analysis. Stil I guess we should fill in PR for missed optimization and solve the forwprop issue? Honza Index: ChangeLog === *** ChangeLog (revision 178523) --- ChangeLog (working c

Re: Propagate BB predicates in ipa-inline-analysis

2011-09-03 Thread Jan Hubicka
> tree-ssa-forwprop.c I presume? That one misses calling fold_stmt when > it propagates things. Yep. > > > : > >  iftmp.1_9 = 0; > > > > : > >  # iftmp.1_2 = PHI <1(4), 0(5)> > >  D.2739_10 = __builtin_constant_p (iftmp.1_2); > > But I wonder how it manages to do something to the above ... (are

Re: Propagate BB predicates in ipa-inline-analysis

2011-09-03 Thread Richard Guenther
On Sat, Sep 3, 2011 at 6:41 PM, Jan Hubicka wrote: >> Jan Hubicka wrote: >> >> >     (edge_execution_predicate): Rewrite as... >> >     (set_cond_stmt_execution_predicate): ... this function; handle >> >     __builtin_constant_p. >> >> This causes ICEs when building recent Linux kernels with the >

Re: Propagate BB predicates in ipa-inline-analysis

2011-09-03 Thread Jan Hubicka
> Jan Hubicka wrote: > > > (edge_execution_predicate): Rewrite as... > > (set_cond_stmt_execution_predicate): ... this function; handle > > __builtin_constant_p. > > This causes ICEs when building recent Linux kernels with the > CONFIG_TRACE_BRANCH_PROFLING option. This reduced test

Re: Propagate BB predicates in ipa-inline-analysis

2011-09-03 Thread Richard Guenther
On Fri, Sep 2, 2011 at 7:42 PM, Ulrich Weigand wrote: > Jan Hubicka wrote: > >>       (edge_execution_predicate): Rewrite as... >>       (set_cond_stmt_execution_predicate): ... this function; handle >>       __builtin_constant_p. > > This causes ICEs when building recent Linux kernels with the >

Re: Propagate BB predicates in ipa-inline-analysis

2011-09-02 Thread Ulrich Weigand
Jan Hubicka wrote: > (edge_execution_predicate): Rewrite as... > (set_cond_stmt_execution_predicate): ... this function; handle > __builtin_constant_p. This causes ICEs when building recent Linux kernels with the CONFIG_TRACE_BRANCH_PROFLING option. This reduced test case: sta

Re: Propagate BB predicates in ipa-inline-analysis

2011-05-08 Thread H.J. Lu
On Fri, Apr 29, 2011 at 2:18 PM, Jan Hubicka wrote: > Hi, > this more or less complettes the infrastructure for predicates by adding > logic propagating predicates across CFG.  I also added switch statement > handling and __builtin_constant_p construct, so we "understand" functions > using those a

Propagate BB predicates in ipa-inline-analysis

2011-04-29 Thread Jan Hubicka
Hi, this more or less complettes the infrastructure for predicates by adding logic propagating predicates across CFG. I also added switch statement handling and __builtin_constant_p construct, so we "understand" functions using those as one in the new testcase. It also turned out that the predica