Re: Ping [PATCH V2] libcpp: Optimize #pragma once with a hash table [PR58770]

2022-08-23 Thread Nathan Sidwell via Gcc-patches
On 8/22/22 13:39, Paul Hollinsky wrote: On Mon, Aug 22, 2022 at 09:19:29AM -0400, Nathan Sidwell wrote: On 8/19/22 16:27, Paul Hollinsky wrote: Hi all, Would love some feedback on this patch! Thanks, Paul On Mon, Aug 01, 2022 at 05:18:40AM +, Paul Hollinsky wrote: Rather than traversing

Re: Ping [PATCH V2] libcpp: Optimize #pragma once with a hash table [PR58770]

2022-08-22 Thread Paul Hollinsky via Gcc-patches
On Sun, Aug 21, 2022 at 08:40:26PM +0100, David Malcolm wrote: > On Fri, 2022-08-19 at 13:27 -0700, Paul Hollinsky wrote: > > Hi all, > > > > Would love some feedback on this patch! > > > > Thanks, > > Paul > > Hi Paul. Sorry for not getting back to you before. I'm listed as a > libcpp maintain

Re: Ping [PATCH V2] libcpp: Optimize #pragma once with a hash table [PR58770]

2022-08-22 Thread Paul Hollinsky via Gcc-patches
On Mon, Aug 22, 2022 at 09:19:29AM -0400, Nathan Sidwell wrote: > On 8/19/22 16:27, Paul Hollinsky wrote: > > Hi all, > > > > Would love some feedback on this patch! > > > > Thanks, > > Paul > > > > On Mon, Aug 01, 2022 at 05:18:40AM +, Paul Hollinsky wrote: > > > Rather than traversing the

Re: Ping [PATCH V2] libcpp: Optimize #pragma once with a hash table [PR58770]

2022-08-22 Thread Nathan Sidwell via Gcc-patches
On 8/19/22 16:27, Paul Hollinsky wrote: Hi all, Would love some feedback on this patch! Thanks, Paul On Mon, Aug 01, 2022 at 05:18:40AM +, Paul Hollinsky wrote: Rather than traversing the all_files linked list for every include, this factors out the quick idempotency checks (modification

Re: Ping [PATCH V2] libcpp: Optimize #pragma once with a hash table [PR58770]

2022-08-21 Thread David Malcolm via Gcc-patches
On Fri, 2022-08-19 at 13:27 -0700, Paul Hollinsky wrote: > Hi all, > > Would love some feedback on this patch! > > Thanks, > Paul Hi Paul. Sorry for not getting back to you before. I'm listed as a libcpp maintainer, but this happens to be a part of libcpp I've not looked at (I'm mostly just fam

Ping [PATCH V2] libcpp: Optimize #pragma once with a hash table [PR58770]

2022-08-19 Thread Paul Hollinsky via Gcc-patches
Hi all, Would love some feedback on this patch! Thanks, Paul On Mon, Aug 01, 2022 at 05:18:40AM +, Paul Hollinsky wrote: > Rather than traversing the all_files linked list for every include, > this factors out the quick idempotency checks (modification time > and size) to be the keys in a ha