RE: RFA: another patch to fix PR61360

2014-09-24 Thread Gopalasubramanian, Ganesh
>The "r->x" alternative results in "vector" decoding on amdfam10. This is >AMD-speak for microcoded instructions, and AMD optimization manual strongly >recommends avoiding them. I have CC'd Ganesh, maybe he >can provide more >relevant data on the performance impact. Thanks Uros! Yes, the AMD S

Re: RFA: another patch to fix PR61360

2014-09-23 Thread Richard Biener
On September 23, 2014 5:33:35 PM CEST, Uros Bizjak wrote: >On Tue, Sep 23, 2014 at 5:22 PM, Vladimir Makarov >wrote: > You are right constrain_operands is not upto LRA possibilities and >we should make the following change: Index: recog.c ==

Re: RFA: another patch to fix PR61360

2014-09-23 Thread Uros Bizjak
On Tue, Sep 23, 2014 at 5:22 PM, Vladimir Makarov wrote: >>> You are right constrain_operands is not upto LRA possibilities and we >>> should make the following change: >>> >>> Index: recog.c >>> === >>> --- recog.c (revision 21

Re: RFA: another patch to fix PR61360

2014-09-23 Thread Uros Bizjak
On Tue, Sep 23, 2014 at 5:02 PM, Uros Bizjak wrote: >>> On Tue, Sep 23, 2014 at 3:26 AM, Vladimir Makarov >>> wrote: The previous patch to solve PR61360 fixed the problem in IRA (it was easier for me to do as I know the code well) https://gcc.gnu.org/bugzilla/show_bug.cgi?

Re: RFA: another patch to fix PR61360

2014-09-23 Thread Vladimir Makarov
On 09/23/2014 11:02 AM, Uros Bizjak wrote: > On Tue, Sep 23, 2014 at 4:52 PM, Vladimir Makarov wrote: >> On 09/23/2014 02:07 AM, Uros Bizjak wrote: >>> >> Uros, my patch does not result in PR60704 (I tested it before submitting >> the patch). > No, we didn't understand each other. The fix for PR60

Re: RFA: another patch to fix PR61360

2014-09-23 Thread Uros Bizjak
On Tue, Sep 23, 2014 at 4:52 PM, Vladimir Makarov wrote: > On 09/23/2014 02:07 AM, Uros Bizjak wrote: >> On Tue, Sep 23, 2014 at 3:26 AM, Vladimir Makarov >> wrote: >>> The previous patch to solve PR61360 fixed the problem in IRA (it was >>> easier for me to do as I know the code well) >>> >>>

Re: RFA: another patch to fix PR61360

2014-09-23 Thread Vladimir Makarov
On 09/23/2014 02:07 AM, Uros Bizjak wrote: > On Tue, Sep 23, 2014 at 3:26 AM, Vladimir Makarov wrote: >> The previous patch to solve PR61360 fixed the problem in IRA (it was >> easier for me to do as I know the code well) >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 >> >> Although

Re: RFA: another patch to fix PR61360

2014-09-22 Thread Uros Bizjak
On Tue, Sep 23, 2014 at 3:26 AM, Vladimir Makarov wrote: > The previous patch to solve PR61360 fixed the problem in IRA (it was > easier for me to do as I know the code well) > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 > > Although imo it was an ok fix, Richard expressed concerns wi

RFA: another patch to fix PR61360

2014-09-22 Thread Vladimir Makarov
The previous patch to solve PR61360 fixed the problem in IRA (it was easier for me to do as I know the code well) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 Although imo it was an ok fix, Richard expressed concerns with the patch and the practice to have different enable attribute

Re: Patch to fix PR61360

2014-09-18 Thread Richard Sandiford
Vladimir Makarov writes: > On 09/18/2014 01:36 PM, Richard Sandiford wrote: >> Jakub Jelinek writes: >>> On Thu, Sep 18, 2014 at 12:04:30PM -0400, Vladimir Makarov wrote: The following patch fixes the PR. The details can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=613

Re: Patch to fix PR61360

2014-09-18 Thread Vladimir Makarov
On 09/18/2014 01:36 PM, Richard Sandiford wrote: > Jakub Jelinek writes: >> On Thu, Sep 18, 2014 at 12:04:30PM -0400, Vladimir Makarov wrote: >>> The following patch fixes the PR. The details can be found on >>> >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 >>> >>> The patch was bootstra

Re: Patch to fix PR61360

2014-09-18 Thread Richard Sandiford
Jakub Jelinek writes: > On Thu, Sep 18, 2014 at 12:04:30PM -0400, Vladimir Makarov wrote: >> The following patch fixes the PR. The details can be found on >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 >> >> The patch was bootstrapped and tested on x86/x86-64. >> >> Committed as rev.

Re: Patch to fix PR61360

2014-09-18 Thread Vladimir Makarov
On 09/18/2014 12:10 PM, Jakub Jelinek wrote: > On Thu, Sep 18, 2014 at 12:04:30PM -0400, Vladimir Makarov wrote: >> The following patch fixes the PR. The details can be found on >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 >> >> The patch was bootstrapped and tested on x86/x86-64. >> >

Re: Patch to fix PR61360

2014-09-18 Thread Jakub Jelinek
On Thu, Sep 18, 2014 at 12:04:30PM -0400, Vladimir Makarov wrote: > The following patch fixes the PR. The details can be found on > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 > > The patch was bootstrapped and tested on x86/x86-64. > > Committed as rev. 215358. What effect does this

Patch to fix PR61360

2014-09-18 Thread Vladimir Makarov
The following patch fixes the PR. The details can be found on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61360 The patch was bootstrapped and tested on x86/x86-64. Committed as rev. 215358. 2014-09-18 Vladimir Makarov PR target/61360 * lra.c (lra): Call recog_init. 2014-