Re: Patch to align local PowerPC AltiVec arrays

2011-04-17 Thread Wellander, Pat - Code Sourcery
Actually, after reinvestigating this, "AFAIK, the vectorizer is smart enough to automagically increase alignment on global arrays" so is not of concern to Freescale. Also, Changing the alignment of arrays within structs would change the field layout and would violate the ABI and be incompatible wit

Re: Patch to align local PowerPC AltiVec arrays

2011-03-21 Thread Wellander, Pat - Code Sourcery
On 3/21/2011 3:26 PM, Andrew Pinski wrote: On Mon, Mar 21, 2011 at 3:25 PM, Andrew Pinski wrote: On Mon, Mar 21, 2011 at 3:21 PM, Wellander, Pat - Code Sourcery wrote: The stack is aligned at 16 bytes with AltiVec (if not, this patch would not make sense). Also, all char arrays are aligned a

Re: Patch to align local PowerPC AltiVec arrays

2011-03-21 Thread Andrew Pinski
On Mon, Mar 21, 2011 at 3:25 PM, Andrew Pinski wrote: > On Mon, Mar 21, 2011 at 3:21 PM, Wellander, Pat - Code Sourcery > wrote: >> The stack is aligned at 16 bytes with AltiVec (if not, this patch would not >> make sense). >> Also, all char arrays are aligned at 16 bytes. >> This patch causes ot

Re: Patch to align local PowerPC AltiVec arrays

2011-03-21 Thread Andrew Pinski
On Mon, Mar 21, 2011 at 3:21 PM, Wellander, Pat - Code Sourcery wrote: > The stack is aligned at 16 bytes with AltiVec (if not, this patch would not > make sense). > Also, all char arrays are aligned at 16 bytes. > This patch causes other local stack arrays >= 16 bytes to be aligned at 16 > bytes

Re: Patch to align local PowerPC AltiVec arrays

2011-03-21 Thread Wellander, Pat - Code Sourcery
The stack is aligned at 16 bytes with AltiVec (if not, this patch would not make sense). Also, all char arrays are aligned at 16 bytes. This patch causes other local stack arrays >= 16 bytes to be aligned at 16 bytes in order to make more effective use of AltiVec instructions. On 3/21/2011 3:0

Re: Patch to align local PowerPC AltiVec arrays

2011-03-21 Thread Andrew Pinski
On Mon, Mar 21, 2011 at 2:54 PM, Wellander, Pat - Code Sourcery wrote: > This is my first patch submittal so constructive criticism is appreciated. > This patch causes PowerPC AltiVec local stack arrays > 16 bytes to be > aligned at 16 bytes. Wait I thought the alignment of the stack is 16 bytes

Patch to align local PowerPC AltiVec arrays

2011-03-21 Thread Wellander, Pat - Code Sourcery
This is my first patch submittal so constructive criticism is appreciated. This patch causes PowerPC AltiVec local stack arrays > 16 bytes to be aligned at 16 bytes. 2011-01-27 Pat Wellander * config/rs6000/rs6000.h (LOCAL_ALIGNMENT): AltiVec local arrays >= 16 bytes are now aligned to