Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-07 Thread Ian Lance Taylor
On Fri, Mar 7, 2014 at 4:12 AM, Rainer Orth wrote: > Hi Paolo, > >> On 03/05/2014 04:34 AM, Ian Lance Taylor wrote: >>> The GNU glibc qsort function will call malloc in some cases. That makes >>> it unsuitable for libbacktrace, which is intended to work when called >>> from a signal handler. Th

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-07 Thread Jakub Jelinek
On Fri, Mar 07, 2014 at 01:12:02PM +0100, Rainer Orth wrote: > 2014-03-07 Rainer Orth > > * libbacktrace/Makefile.am (libsanitizer_libbacktrace_la_SOURCES): > Add ../../libbacktrace/sort.c. > * libbacktrace/Makefile.in: Regenerate. > * libbacktrace/backtrace-rename.h (ba

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-07 Thread Paolo Carlini
Hi, On 03/07/2014 01:12 PM, Rainer Orth wrote: Hi Paolo, On 03/05/2014 04:34 AM, Ian Lance Taylor wrote: The GNU glibc qsort function will call malloc in some cases. That makes it unsuitable for libbacktrace, which is intended to work when called from a signal handler. This patch changes li

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-07 Thread Rainer Orth
Hi Paolo, > On 03/05/2014 04:34 AM, Ian Lance Taylor wrote: >> The GNU glibc qsort function will call malloc in some cases. That makes >> it unsuitable for libbacktrace, which is intended to work when called >> from a signal handler. This patch changes libbacktrace to use an >> internal qsort fu

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-07 Thread Paolo Carlini
Hi, On 03/05/2014 04:34 AM, Ian Lance Taylor wrote: The GNU glibc qsort function will call malloc in some cases. That makes it unsuitable for libbacktrace, which is intended to work when called from a signal handler. This patch changes libbacktrace to use an internal qsort function. I'm posti

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-06 Thread Ian Lance Taylor
On Tue, Mar 4, 2014 at 7:34 PM, Ian Lance Taylor wrote: > The GNU glibc qsort function will call malloc in some cases. That makes > it unsuitable for libbacktrace, which is intended to work when called > from a signal handler. This patch changes libbacktrace to use an > internal qsort function.

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-05 Thread Ian Lance Taylor
On Wed, Mar 5, 2014 at 9:17 AM, Ondřej Bílka wrote: > On Wed, Mar 05, 2014 at 08:05:25AM -0800, Ian Lance Taylor wrote: >> On Wed, Mar 5, 2014 at 1:25 AM, Richard Biener >> wrote: >> > On Wed, Mar 5, 2014 at 4:34 AM, Ian Lance Taylor wrote: >> >> The GNU glibc qsort function will call malloc in

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-05 Thread Ondřej Bílka
On Wed, Mar 05, 2014 at 08:05:25AM -0800, Ian Lance Taylor wrote: > On Wed, Mar 5, 2014 at 1:25 AM, Richard Biener > wrote: > > On Wed, Mar 5, 2014 at 4:34 AM, Ian Lance Taylor wrote: > >> The GNU glibc qsort function will call malloc in some cases. That makes > >> it unsuitable for libbacktrace

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-05 Thread Ian Lance Taylor
On Wed, Mar 5, 2014 at 1:25 AM, Richard Biener wrote: > On Wed, Mar 5, 2014 at 4:34 AM, Ian Lance Taylor wrote: >> The GNU glibc qsort function will call malloc in some cases. That makes >> it unsuitable for libbacktrace, which is intended to work when called >> from a signal handler. This patc

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-05 Thread Steven Bosscher
On Wed, Mar 5, 2014 at 10:25 AM, Richard Biener wrote: > On Wed, Mar 5, 2014 at 4:34 AM, Ian Lance Taylor wrote: >> The GNU glibc qsort function will call malloc in some cases. That makes >> it unsuitable for libbacktrace, which is intended to work when called >> from a signal handler. This patch

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-05 Thread Richard Biener
On Wed, Mar 5, 2014 at 4:34 AM, Ian Lance Taylor wrote: > The GNU glibc qsort function will call malloc in some cases. That makes > it unsuitable for libbacktrace, which is intended to work when called > from a signal handler. This patch changes libbacktrace to use an > internal qsort function.

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-04 Thread Ian Lance Taylor
On Tue, Mar 4, 2014 at 8:03 PM, Patrick Palka wrote: > On Tue, Mar 4, 2014 at 10:34 PM, Ian Lance Taylor wrote: >> The GNU glibc qsort function will call malloc in some cases. That makes >> it unsuitable for libbacktrace, which is intended to work when called >> from a signal handler. This patc

Re: Patch RFC: Use internal qsort function in libbacktrace

2014-03-04 Thread Patrick Palka
On Tue, Mar 4, 2014 at 10:34 PM, Ian Lance Taylor wrote: > The GNU glibc qsort function will call malloc in some cases. That makes > it unsuitable for libbacktrace, which is intended to work when called > from a signal handler. This patch changes libbacktrace to use an > internal qsort function.

Patch RFC: Use internal qsort function in libbacktrace

2014-03-04 Thread Ian Lance Taylor
The GNU glibc qsort function will call malloc in some cases. That makes it unsuitable for libbacktrace, which is intended to work when called from a signal handler. This patch changes libbacktrace to use an internal qsort function. I'm posting this for comments in case anybody sees anything wron