Re: Patch RFC: Avoid recursive insert into const_desc_htab

2019-02-21 Thread Ian Lance Taylor
On Thu, Feb 21, 2019 at 1:57 AM Richard Biener wrote: > > On Wed, Feb 20, 2019 at 6:53 PM Ian Lance Taylor wrote: > > > > The underlying cause of PR 89170 is a bug that appears to have existed > > since 2001, when the function decode_addr_const was changed to call > > output_constant_def. The pr

Re: Patch RFC: Avoid recursive insert into const_desc_htab

2019-02-21 Thread Richard Biener
On Wed, Feb 20, 2019 at 6:53 PM Ian Lance Taylor wrote: > > The underlying cause of PR 89170 is a bug that appears to have existed > since 2001, when the function decode_addr_const was changed to call > output_constant_def. The problem is that output_constant_def calls > compare_constant, and whe

Patch RFC: Avoid recursive insert into const_desc_htab

2019-02-20 Thread Ian Lance Taylor
The underlying cause of PR 89170 is a bug that appears to have existed since 2001, when the function decode_addr_const was changed to call output_constant_def. The problem is that output_constant_def calls compare_constant, and when compare_constant sees an ADDR_EXPR, it calls decode_addr_const.