Re: PR81703 and Martin's fix for PR83501

2018-01-14 Thread Prathamesh Kulkarni
On 12 January 2018 at 23:25, Jakub Jelinek wrote: > On Fri, Jan 12, 2018 at 10:38:39AM -0700, Jeff Law wrote: >> >>> Thanks for pointing it out. I see it there as well with >> >>> Prathamesh's test case, though not with the test case in >> >>> bug 83543. It is the same root cause in both. I agr

Re: PR81703 and Martin's fix for PR83501

2018-01-12 Thread Jakub Jelinek
On Fri, Jan 12, 2018 at 10:38:39AM -0700, Jeff Law wrote: > >>> Thanks for pointing it out.  I see it there as well with > >>> Prathamesh's test case, though not with the test case in > >>> bug 83543.  It is the same root cause in both.  I agree > >>> that enhancing the strlen pass to handle this c

Re: PR81703 and Martin's fix for PR83501

2018-01-12 Thread Jeff Law
On 01/12/2018 09:23 AM, Martin Sebor wrote: > On 01/11/2018 11:44 PM, Prathamesh Kulkarni wrote: >> On 12 January 2018 at 06:15, Martin Sebor wrote: >>> On 01/11/2018 02:48 PM, Rainer Orth wrote: Hi Martin, >> I am not sure why constant string is not emitted for >> arm-linux

Re: PR81703 and Martin's fix for PR83501

2018-01-12 Thread Martin Sebor
On 01/11/2018 11:44 PM, Prathamesh Kulkarni wrote: On 12 January 2018 at 06:15, Martin Sebor wrote: On 01/11/2018 02:48 PM, Rainer Orth wrote: Hi Martin, I am not sure why constant string is not emitted for arm-linux-gnueabihf ? As far as this issue is concerned, should I simply XFAIL it on

Re: PR81703 and Martin's fix for PR83501

2018-01-11 Thread Prathamesh Kulkarni
On 12 January 2018 at 06:15, Martin Sebor wrote: > On 01/11/2018 02:48 PM, Rainer Orth wrote: >> >> Hi Martin, >> I am not sure why constant string is not emitted for arm-linux-gnueabihf ? As far as this issue is concerned, should I simply XFAIL it on arm for now ? >>> >>> >>>

Re: PR81703 and Martin's fix for PR83501

2018-01-11 Thread Martin Sebor
On 01/11/2018 02:48 PM, Rainer Orth wrote: Hi Martin, I am not sure why constant string is not emitted for arm-linux-gnueabihf ? As far as this issue is concerned, should I simply XFAIL it on arm for now ? This is not unique to the arm back end but affects other targets as well, including pow

Re: PR81703 and Martin's fix for PR83501

2018-01-11 Thread Rainer Orth
Hi Martin, >> I am not sure why constant string is not emitted for arm-linux-gnueabihf ? >> As far as this issue is concerned, should I simply XFAIL it on arm for now ? > > This is not unique to the arm back end but affects other targets > as well, including powerpc64. There's a bug open (PR 8346

Re: PR81703 and Martin's fix for PR83501

2018-01-11 Thread Martin Sebor
x for PR83501 posted here since both had considerable overlaps: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00180.html The patch passes bootstrap+test on x86_64-unknown-linux-gnu and cross-tested on aarch64-*-*. Currently it fails to pass validation on arm targets because of PR83775. I don't

Re: PR81703 and Martin's fix for PR83501

2018-01-11 Thread Prathamesh Kulkarni
On 11 January 2018 at 16:14, Prathamesh Kulkarni wrote: > On 11 January 2018 at 14:52, Christophe Lyon > wrote: >> Hi >> >> On 10 January 2018 at 19:42, Prathamesh Kulkarni >> wrote: >>> Hi, >>> I have attached patch for PR81703 rebased on Mar

Re: PR81703 and Martin's fix for PR83501

2018-01-11 Thread Prathamesh Kulkarni
On 11 January 2018 at 14:52, Christophe Lyon wrote: > Hi > > On 10 January 2018 at 19:42, Prathamesh Kulkarni > wrote: >> Hi, >> I have attached patch for PR81703 rebased on Martin's fix for PR83501 >> posted here since both had considerable overlaps: >>

Re: PR81703 and Martin's fix for PR83501

2018-01-11 Thread Christophe Lyon
Hi On 10 January 2018 at 19:42, Prathamesh Kulkarni wrote: > Hi, > I have attached patch for PR81703 rebased on Martin's fix for PR83501 > posted here since both had considerable overlaps: > https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00180.html > > The patch passes b

Re: PR81703 and Martin's fix for PR83501

2018-01-10 Thread Jeff Law
On 01/10/2018 11:42 AM, Prathamesh Kulkarni wrote: > Hi, > I have attached patch for PR81703 rebased on Martin's fix for PR83501 > posted here since both had considerable overlaps: > https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00180.html > > The patch passes bootstrap

PR81703 and Martin's fix for PR83501

2018-01-10 Thread Prathamesh Kulkarni
Hi, I have attached patch for PR81703 rebased on Martin's fix for PR83501 posted here since both had considerable overlaps: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00180.html The patch passes bootstrap+test on x86_64-unknown-linux-gnu and cross-tested on aarch64-*-*. Currently it fai

Re: [PATCH] minor tweak to complete strlen fix for PR83501

2018-01-04 Thread Jeff Law
On 01/03/2018 02:29 PM, Martin Sebor wrote: > Prathamesh's fix restores the optimization for the test case > reported in the bug (thanks!) but it isn't sufficient to bring > GCC 8 completely up to par with 7.  Prior GCC versions are able > to compute the string length in the test case below but GCC

[PATCH] minor tweak to complete strlen fix for PR83501

2018-01-03 Thread Martin Sebor
Prathamesh's fix restores the optimization for the test case reported in the bug (thanks!) but it isn't sufficient to bring GCC 8 completely up to par with 7. Prior GCC versions are able to compute the string length in the test case below but GCC 8 cannot. char d[8]; const char s[] = "123456

Re: PR83501

2018-01-03 Thread Prathamesh Kulkarni
On 2 January 2018 at 19:29, Richard Biener wrote: > On Thu, Dec 28, 2017 at 8:42 AM, Prathamesh Kulkarni > wrote: >> On 21 December 2017 at 12:53, Prathamesh Kulkarni >> wrote: >>> Hi Jakub, >>> Based on your suggestions in PR83501, I have updated the patc

Re: PR83501

2018-01-02 Thread Richard Biener
On Thu, Dec 28, 2017 at 8:42 AM, Prathamesh Kulkarni wrote: > On 21 December 2017 at 12:53, Prathamesh Kulkarni > wrote: >> Hi Jakub, >> Based on your suggestions in PR83501, I have updated the patch to >> check for integer_zerop for 2nd operand of mem_ref. >> &g

Re: PR83501

2017-12-27 Thread Prathamesh Kulkarni
On 21 December 2017 at 12:53, Prathamesh Kulkarni wrote: > Hi Jakub, > Based on your suggestions in PR83501, I have updated the patch to > check for integer_zerop for 2nd operand of mem_ref. > > With the patch, Warray-bounds started warning for the following test > in Warray-

PR83501

2017-12-20 Thread Prathamesh Kulkarni
Hi Jakub, Based on your suggestions in PR83501, I have updated the patch to check for integer_zerop for 2nd operand of mem_ref. With the patch, Warray-bounds started warning for the following test in Warray-bounds-3.c in line 362 and thus I removed xfail on it: TM (a5, "0123", ma.a5