Re: PR53914, rs6000 constraints and reload queries

2012-10-29 Thread David Edelsohn
On Wed, Aug 1, 2012 at 9:52 AM, Alan Modra wrote: > Hi David, > This is the last of my vendetta against the "o" constraint in the > rs6000 backend. Remaining are a few places in rs6000.md where the > operand predicate is offsettable_mem_operand, and one instance in > spe.md. I believe none of th

Re: PR53914, rs6000 constraints and reload queries

2012-08-01 Thread Alan Modra
Hi David, This is the last of my vendetta against the "o" constraint in the rs6000 backend. Remaining are a few places in rs6000.md where the operand predicate is offsettable_mem_operand, and one instance in spe.md. I believe none of these can run into mode_dependent_address causing "insn does no

Re: PR53914, rs6000 constraints and reload queries

2012-07-23 Thread Alan Modra
On Mon, Jul 23, 2012 at 07:30:23PM -0400, David Edelsohn wrote: > This is okay Committed revision 189801. PR target/53914 PR target/54009 * config/rs6000/constraints.md (Y): Use mem_operand_gpr. * config/rs6000/predicates.md (word_offset_memref_operand): Delete.

Re: PR53914, rs6000 constraints and reload queries

2012-07-21 Thread David Edelsohn
On Thu, Jul 19, 2012 at 8:45 PM, Alan Modra wrote: > This on the other hand works. Please consider the patch amended to > remove mem_operand_fpr, the 'wY' constraint, and uses thereof replaced > with "m". What, exactly, is the current proposed patch? Remove offsettable address constraint from m

Re: PR53914, rs6000 constraints and reload queries

2012-07-19 Thread Alan Modra
On Fri, Jul 20, 2012 at 12:05:28AM +0930, Alan Modra wrote: > On Thu, Jul 19, 2012 at 12:34:25PM +0930, Alan Modra wrote: > > and fixes pr54009. > > David, in looking over this today, I realised that this bug isn't > completely fixed. I stopped gcc emitting an offset of 32768, but that > isn't en

Re: PR53914, rs6000 constraints and reload queries

2012-07-19 Thread Alan Modra
On Thu, Jul 19, 2012 at 12:34:25PM +0930, Alan Modra wrote: > and fixes pr54009. David, in looking over this today, I realised that this bug isn't completely fixed. I stopped gcc emitting an offset of 32768, but that isn't enough. lo_sum addresses can't be offset, except when you know the alignm

Re: PR53914, rs6000 constraints and reload queries

2012-07-18 Thread Alan Modra
Thanks very much Uli for verifying my conclusions about reload, operand predicates and constraints, and particularly the general unusability of the "o" constraint. Re http://gcc.gnu.org/ml/gcc/2012-07/msg00142.html, this patch adds the missing secondary reload patterns, corrects constraints I got