Re: PR rtl-optimization/51771: revert TM returns twice kludge

2012-12-07 Thread Richard Henderson
On 2012-12-07 14:11, Aldy Hernandez wrote: > I am hoping that by removing this hack we can find actual problems. > > However, if you believe the RTL edge dropping in gimple_expand_cfg() is > problematic, I can look into fixing this, though it would be nice to have a > test I can work off of. Le

Re: PR rtl-optimization/51771: revert TM returns twice kludge

2012-12-07 Thread Aldy Hernandez
On 12/07/12 14:04, Richard Henderson wrote: On 2012-12-05 15:06, Aldy Hernandez wrote: PR rtl-optimization/51771 Revert: * builtin-attrs.def (ATTR_RETURNS_TWICE, ATTR_TM_NOTHROW_RT_LIST): New. * gtm-builtins.def (BUILT_IN_TM_START): Add returns-twice attrib. Are

Re: PR rtl-optimization/51771: revert TM returns twice kludge

2012-12-07 Thread Richard Henderson
On 2012-12-05 15:06, Aldy Hernandez wrote: > PR rtl-optimization/51771 > Revert: > * builtin-attrs.def (ATTR_RETURNS_TWICE, ATTR_TM_NOTHROW_RT_LIST): New. > * gtm-builtins.def (BUILT_IN_TM_START): Add returns-twice attrib. Are we absolutely sure that the rtl edges are fixed

PR rtl-optimization/51771: revert TM returns twice kludge

2012-12-05 Thread Aldy Hernandez
As mentioned in the PR, this seems to no longer be an issue after we redesigned the TM abnormal edges (in the uninstrumented code path patchset). Tested with the STAMP benchmark for both 1 and 4 threads, as well as with the GCC regression suite. OK for trunk? commit 462e1c25a81bfb575a9113e4d1