Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-10-29 Thread Manuel López-Ibáñez
On 29 October 2012 02:18, Joseph S. Myers wrote: > The code changes seem fine, but I don't think a testcase should depend on > the details of what system strings.h declares (or even that it exists) > like that. If you want a system header declaration, add a header to the > testsuite that uses #pr

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-10-28 Thread Joseph S. Myers
The code changes seem fine, but I don't think a testcase should depend on the details of what system strings.h declares (or even that it exists) like that. If you want a system header declaration, add a header to the testsuite that uses #pragma GCC system_header to be sure it's handled as such

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-10-27 Thread Manuel López-Ibáñez
On 25 April 2012 13:54, Joseph S. Myers wrote: > On Wed, 25 Apr 2012, Manuel López-Ibáñez wrote: > >> On 25 April 2012 00:01, Joseph S. Myers wrote: >> > On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: >> > >> >> Wshadow warns whenever any declaration shadows a global function >> >> declaration.

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 6:54 AM, Joseph S. Myers wrote: > On Wed, 25 Apr 2012, Manuel López-Ibáñez wrote: > >> On 25 April 2012 00:01, Joseph S. Myers wrote: >> > On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: >> > >> >> Wshadow warns whenever any declaration shadows a global function >> >> decl

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 5:36 AM, Manuel López-Ibáñez wrote: > On 25 April 2012 00:01, Joseph S. Myers wrote: >> On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: >> >>> Wshadow warns whenever any declaration shadows a global function >>> declaration. This is almost always noise, since most (always?

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-25 Thread Joseph S. Myers
On Wed, 25 Apr 2012, Manuel López-Ibáñez wrote: > On 25 April 2012 00:01, Joseph S. Myers wrote: > > On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: > > > >> Wshadow warns whenever any declaration shadows a global function > >> declaration. This is almost always noise, since most (always?) of the

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-25 Thread Manuel López-Ibáñez
On 25 April 2012 00:01, Joseph S. Myers wrote: > On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: > >> Wshadow warns whenever any declaration shadows a global function >> declaration. This is almost always noise, since most (always?) of the >> time one cannot mistakenly replace a function by anothe

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-24 Thread Joseph S. Myers
On Sun, 22 Apr 2012, Manuel L?pez-Ib??ez wrote: > Wshadow warns whenever any declaration shadows a global function > declaration. This is almost always noise, since most (always?) of the > time one cannot mistakenly replace a function by another variable. The > false positives are too common (Linu

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-22 Thread Gabriel Dos Reis
On Sun, Apr 22, 2012 at 11:00 AM, Manuel López-Ibáñez wrote: > As described by Linus here: > Interestingly, the C++ FE does not warn for this case, but it is not > very clear to me where this decision is taken. C++'s type system does not make it very likely to get into the troubles that -Wshadow

PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-22 Thread Manuel López-Ibáñez
As described by Linus here: http://lkml.indiana.edu/hypermail/linux/kernel/0611.3/1020.html Wshadow warns whenever any declaration shadows a global function declaration. This is almost always noise, since most (always?) of the time one cannot mistakenly replace a function by another variable. The