Re: PR c/53063 Handle Wformat with LangEnabledBy

2012-11-03 Thread Joseph S. Myers
On Sat, 27 Oct 2012, Manuel L?pez-Ib??ez wrote: > On 19 October 2012 18:17, Joseph S. Myers wrote: > > On Wed, 17 Oct 2012, Manuel L?pez-Ib??ez wrote: > > > >> documentation but I can also implement -Wformat=0 being an alias for > >> -Wno-format and -Wformat=1 an alias for -Wformat and simply rej

Re: PR c/53063 Handle Wformat with LangEnabledBy

2012-10-27 Thread Manuel López-Ibáñez
On 19 October 2012 18:17, Joseph S. Myers wrote: > On Wed, 17 Oct 2012, Manuel López-Ibáñez wrote: > >> documentation but I can also implement -Wformat=0 being an alias for >> -Wno-format and -Wformat=1 an alias for -Wformat and simply reject >> -Wno-format=. > > I think that's what's wanted; -Wno

Re: PR c/53063 Handle Wformat with LangEnabledBy

2012-10-23 Thread Joseph S. Myers
On Tue, 23 Oct 2012, Manuel López-Ibáñez wrote: > The problem is how to represent that Wformat-y2k is enabled by > -Wformat=X with X >= 2, while Wformat-zero-length is enabled by X >=1. > > One possiblity is to allow to specify a condition directly: I guess that's reasonable. -- Joseph S. Myer

Re: PR c/53063 Handle Wformat with LangEnabledBy

2012-10-23 Thread Manuel López-Ibáñez
On 19 October 2012 18:17, Joseph S. Myers wrote: > On Wed, 17 Oct 2012, Manuel López-Ibáñez wrote: > >> documentation but I can also implement -Wformat=0 being an alias for >> -Wno-format and -Wformat=1 an alias for -Wformat and simply reject >> -Wno-format=. > > I think that's what's wanted; -Wno

Re: PR c/53063 Handle Wformat with LangEnabledBy

2012-10-19 Thread Joseph S. Myers
On Wed, 17 Oct 2012, Manuel L?pez-Ib??ez wrote: > documentation but I can also implement -Wformat=0 being an alias for > -Wno-format and -Wformat=1 an alias for -Wformat and simply reject > -Wno-format=. I think that's what's wanted; -Wno-format= should be rejected, -Wformat= should take an arbi

PR c/53063 Handle Wformat with LangEnabledBy

2012-10-17 Thread Manuel López-Ibáñez
Bootstrapped and regression tested on x86_64-linux-gnu. Since Wformat didn't have Var() associated, its corresponding entry was set to -1, which is what warning(OPT_Wformat) checks for. Therefore, any such warnings which were not guarded by if(warn_format), were enabled by default. I only found one