Re: PR 56524: TREE_OPTIMIZATION_OPTABS vs. mips16

2013-03-08 Thread Richard Sandiford
Jakub Jelinek writes: > So I think the > > if (TREE_OPTIMIZATION_OPTABS (optnode)) > ggc_free (TREE_OPTIMIZATION_OPTABS (optnode)); > > has to be removed (of course the second ggc_free, if memcmp returned 0, is > desirable). *blush*. Thanks for catching that. > Otherwise looks goo

Re: PR 56524: TREE_OPTIMIZATION_OPTABS vs. mips16

2013-03-07 Thread Jakub Jelinek
On Thu, Mar 07, 2013 at 10:51:14PM +, Richard Sandiford wrote: > void > -save_optabs_if_changed (tree fndecl) > +init_tree_optimization_optabs (tree optnode) > { > - /* ?? If this fails, we should temporarily restore the default > - target first (set_cfun (NULL) ??), do the rest of this

PR 56524: TREE_OPTIMIZATION_OPTABS vs. mips16

2013-03-07 Thread Richard Sandiford
This assert in save_optabs_if_changed triggered for gcc.dg/pr43564.c on mips64-linux-gnu (-mabi=32/-mips16): /* ?? If this fails, we should temporarily restore the default target first (set_cfun (NULL) ??), do the rest of this function, and then restore it. */ gcc_assert (this_targe