Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

2012-08-13 Thread Peter Bergner
On 08/03/2012 11:28:57 +0200 Paolo Carlini wrote: > No problem ;) Patch is Ok, thanks! Hi Paolo, I see you committed the patch for me. Thanks!! I literally posted that last patch just minutes before heading out on vacation and didn't want to commit it just before I left in case it caused any fa

Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

2012-08-03 Thread Paolo Carlini
Hi, On 08/03/2012 07:00 AM, Peter Bergner wrote: Fixed. Ok, once more with feeling! :) How about the updated patched below? ...and thank you for the gentle review. This is my first libstdc++ patch and I guess I was used to the normal gcc/testsuite/ tests that don't include copyright headers a

Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

2012-08-02 Thread Peter Bergner
On Thu, 02 Aug 2012 11:36:42 Paolo Carlini wrote: > > Also, is this ok for the 4.6 and 4.7 release branches? > I don't think this is a regression, thus I would say 4.7 only, to be safe. Ok. > we don't have a separate ChangeLog in libstdc++-v3/testsuite/. Thus a > single ChangeLog entry for ever

Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

2012-08-02 Thread Paolo Carlini
Hi, On 08/02/2012 01:53 AM, Peter Bergner wrote: So just to be sure, like the patch below? More or less. See comments below. Also, is this ok for the 4.6 and 4.7 release branches? I don't think this is a regression, thus I would say 4.7 only, to be safe. Peter libstdc++-v3/ PR libs

Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

2012-08-01 Thread Peter Bergner
On Wed, 1 Aug 2012 08:24:48 -0700 Janis Johnson wrote: > On 08/01/2012 07:29 AM, Paolo Carlini wrote: > > On 08/01/2012 12:46 AM, Peter Bergner wrote: > >> I'd like to ping the following libstdc++ DFP patch that fixes PR54036: > >> > >>http://gcc.gnu.org/ml/gcc-patches/2012-07/msg00959.html > >

Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

2012-08-01 Thread Janis Johnson
On 08/01/2012 07:29 AM, Paolo Carlini wrote: > Hi, > > On 08/01/2012 12:46 AM, Peter Bergner wrote: >> I'd like to ping the following libstdc++ DFP patch that fixes PR54036: >> >>http://gcc.gnu.org/ml/gcc-patches/2012-07/msg00959.html > I think the patch is essentially Ok, but I would recommen

Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

2012-08-01 Thread Paolo Carlini
Hi, On 08/01/2012 12:46 AM, Peter Bergner wrote: I'd like to ping the following libstdc++ DFP patch that fixes PR54036: http://gcc.gnu.org/ml/gcc-patches/2012-07/msg00959.html I think the patch is essentially Ok, but I would recommend giving Janis a chance to comment (say 24/48 h). Note t

Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

2012-08-01 Thread Jason Merrill
On 07/31/2012 06:46 PM, Peter Bergner wrote: I'd like to ping the following libstdc++ DFP patch that fixes PR54036: http://gcc.gnu.org/ml/gcc-patches/2012-07/msg00959.html I don't normally review library patches; I've added Benjamin to CC, as he's one of the library maintainers. Jason

PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

2012-07-31 Thread Peter Bergner
I'd like to ping the following libstdc++ DFP patch that fixes PR54036: http://gcc.gnu.org/ml/gcc-patches/2012-07/msg00959.html Peter