Re: PATCH to add more FALLTHRU markers

2016-09-29 Thread Jakub Jelinek
On Thu, Sep 29, 2016 at 06:21:13PM +0200, Marek Polacek wrote: > On Tue, Sep 27, 2016 at 09:58:20PM +0200, Jakub Jelinek wrote: > > On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: > > > Not sure if I read this code correctly, but if we fall through from > > > V32HImode, and we have

Re: PATCH to add more FALLTHRU markers

2016-09-29 Thread Marek Polacek
On Tue, Sep 27, 2016 at 07:57:17PM +0100, Richard Sandiford wrote: > Marek Polacek writes: > > Currently Makefile.in contains -Wno-error for several of the insn-* files, > > but > > after further investigation I think with this patch we won't need them > > anymore. > > I'm not removing it until

Re: PATCH to add more FALLTHRU markers

2016-09-29 Thread Marek Polacek
On Tue, Sep 27, 2016 at 09:58:20PM +0200, Jakub Jelinek wrote: > On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: > > Not sure if I read this code correctly, but if we fall through from > > V32HImode, and we have TARGET_SSE2 set, we execute this code: > > > > tmp = "p"; > >

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Jakub Jelinek
On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: > Not sure if I read this code correctly, but if we fall through from > V32HImode, and we have TARGET_SSE2 set, we execute this code: > > tmp = "p"; > ssesuffix = TARGET_AVX512VL ? "q" : ""; > > And not gcc_unreachable ()

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Marek Polacek
On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: > * Marek Polacek: > > > On Tue, Sep 27, 2016 at 08:58:59PM +0200, Florian Weimer wrote: > >> * Marek Polacek: > >> > >> > @@ -11498,21 +11508,23 @@ > >> > case V64QImode: > >> > case V32HImode: > >> >if

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Florian Weimer
* Marek Polacek: > On Tue, Sep 27, 2016 at 08:58:59PM +0200, Florian Weimer wrote: >> * Marek Polacek: >> >> > @@ -11498,21 +11508,23 @@ >> > case V64QImode: >> > case V32HImode: >> >if (TARGET_AVX512F) >> > - { >> > -tmp = "p"; >> > -

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Marek Polacek
On Tue, Sep 27, 2016 at 08:58:59PM +0200, Florian Weimer wrote: > * Marek Polacek: > > > @@ -11498,21 +11508,23 @@ > > case V64QImode: > > case V32HImode: > >if (TARGET_AVX512F) > > - { > > -tmp = "p"; > > -ssesuffix = "q"; > > -

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Florian Weimer
* Marek Polacek: > @@ -11498,21 +11508,23 @@ > case V64QImode: > case V32HImode: >if (TARGET_AVX512F) > - { > -tmp = "p"; > -ssesuffix = "q"; > -break; > - } > + { > + tmp = "p"; > + sse

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Richard Sandiford
Marek Polacek writes: > Currently Makefile.in contains -Wno-error for several of the insn-* files, but > after further investigation I think with this patch we won't need them > anymore. > I'm not removing it until I bootstrap gcc on more arches, though. Meanwhile, > this patch at least makes th

PATCH to add more FALLTHRU markers

2016-09-27 Thread Marek Polacek
Currently Makefile.in contains -Wno-error for several of the insn-* files, but after further investigation I think with this patch we won't need them anymore. I'm not removing it until I bootstrap gcc on more arches, though. Meanwhile, this patch at least makes the code more robust. Richard S., c