Re: PATCH for c++/87068, missing diagnostic with fallthrough statement

2019-02-28 Thread Jakub Jelinek
On Thu, Feb 28, 2019 at 05:16:14PM -0500, Marek Polacek wrote: > 2019-02-28 Marek Polacek > > PR c++/87068 - missing diagnostic with fallthrough statement. > * gimplify.c (expand_FALLTHROUGH_r): If IFN_FALLTHROUGH was found > at the end of a seq, save its location to walk_stmt

Re: PATCH for c++/87068, missing diagnostic with fallthrough statement

2019-02-28 Thread Marek Polacek
On Thu, Aug 30, 2018 at 11:24:50PM +0200, Jakub Jelinek wrote: > On Thu, Aug 30, 2018 at 05:17:03PM -0400, Marek Polacek wrote: > > > 2018-08-23 Marek Polacek > > > > > > PR c++/87068 > > > * gimplify.c (expand_FALLTHROUGH_r): If IFN_FALLTHROUGH was found > > > at the end of a seq, save i

Re: PATCH for c++/87068, missing diagnostic with fallthrough statement

2018-08-30 Thread Jakub Jelinek
On Thu, Aug 30, 2018 at 05:17:03PM -0400, Marek Polacek wrote: > > 2018-08-23 Marek Polacek > > > > PR c++/87068 > > * gimplify.c (expand_FALLTHROUGH_r): If IFN_FALLTHROUGH was found > > at the end of a seq, save its location to walk_stmt_info. > > (expand_FALLTHROUGH): Warn if

Re: PATCH for c++/87068, missing diagnostic with fallthrough statement

2018-08-30 Thread Marek Polacek
Ping. On Thu, Aug 23, 2018 at 04:38:03PM -0400, Marek Polacek wrote: > The C++ standard says that [[fallthrough]]; at the end of a switch statement > is ill-formed: > > Currently we do check that the statement after a fallthrough statement is > a labe

PATCH for c++/87068, missing diagnostic with fallthrough statement

2018-08-23 Thread Marek Polacek
The C++ standard says that [[fallthrough]]; at the end of a switch statement is ill-formed: Currently we do check that the statement after a fallthrough statement is a labeled statement, but we didn't warn if a fallthrough statement is at the very end