Re: PATCH] tree-ssa-sink: Add heuristics for code sinking

2023-04-14 Thread Richard Biener via Gcc-patches
+ } > >> + > >> + if (!gsi_end_p (gsi)) > >> +gsi_prev (&gsi); > >> + } > >> +} > >> + > >> + if (!is_gimple_call (stmt) > >> +

Re: PATCH] tree-ssa-sink: Add heuristics for code sinking

2023-04-14 Thread Ajit Agarwal via Gcc-patches
&& dominated_by_p (CDI_DOMINATORS, sinkbb, frombb) >> + && is_call) >> + return false; >> + > > Sorry, but this lacks a comment, it doesn't explain why the existing > heuristics > are not enough (select_best_block), it repe

Re: PATCH] tree-ssa-sink: Add heuristics for code sinking

2023-04-14 Thread Richard Biener via Gcc-patches
On Fri, Apr 14, 2023 at 10:42 AM Ajit Agarwal via Gcc-patches wrote: > > Hello All: > > This patch add heuristics for code sinking opportunities. > Bootstrapped and regtested for powerpc64-linux-gnu. > > Thanks & Regards > Ajit > > tree-ssa-sink: Add heuristics for code sinking. > >

PATCH] tree-ssa-sink: Add heuristics for code sinking

2023-04-14 Thread Ajit Agarwal via Gcc-patches
Hello All: This patch add heuristics for code sinking opportunities. Bootstrapped and regtested for powerpc64-linux-gnu. Thanks & Regards Ajit tree-ssa-sink: Add heuristics for code sinking. Add following code sinking heuristics: 1. from code block dominates the call.