Re: PATCH: PR rtl-optimization/49504: Invalid optimization for Pmode != ptr_mode

2011-06-24 Thread H.J. Lu
On Fri, Jun 24, 2011 at 7:17 AM, H.J. Lu wrote: > On Fri, Jun 24, 2011 at 7:07 AM, Eric Botcazou wrote: >>> I compared x32 glibc built with the old x32 gcc against x32 glibc built >>> with this patch and >>> >>> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00913.html >>> >>> reverted, the new gli

Re: PATCH: PR rtl-optimization/49504: Invalid optimization for Pmode != ptr_mode

2011-06-24 Thread H.J. Lu
On Fri, Jun 24, 2011 at 7:07 AM, Eric Botcazou wrote: >> I compared x32 glibc built with the old x32 gcc against x32 glibc built >> with this patch and >> >> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00913.html >> >> reverted, the new glibc is little smaller: >> >> New: >> >> [hjl@gnu-33 build-

Re: PATCH: PR rtl-optimization/49504: Invalid optimization for Pmode != ptr_mode

2011-06-24 Thread Eric Botcazou
> I compared x32 glibc built with the old x32 gcc against x32 glibc built > with this patch and > > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00913.html > > reverted, the new glibc is little smaller: > > New: > > [hjl@gnu-33 build-x86_64-linux]$ size libc.so >text data bss d

Re: PATCH: PR rtl-optimization/49504: Invalid optimization for Pmode != ptr_mode

2011-06-24 Thread H.J. Lu
On Fri, Jun 24, 2011 at 1:58 AM, Eric Botcazou wrote: >> I just don't see how nonzero_bits1 can assume if pointers extend unsigned >> and this is an addition or subtraction to a pointer in Pmode, all the bits >> bove ptr_mode are known to be zero.  We never run into it before x32 >> since x32 is t

Re: PATCH: PR rtl-optimization/49504: Invalid optimization for Pmode != ptr_mode

2011-06-24 Thread Eric Botcazou
> I just don't see how nonzero_bits1 can assume if pointers extend unsigned > and this is an addition or subtraction to a pointer in Pmode, all the bits > bove ptr_mode are known to be zero. We never run into it before x32 > since x32 is the first such target. I agree that this is overly optimist

Re: PATCH: PR rtl-optimization/49504: Invalid optimization for Pmode != ptr_mode

2011-06-23 Thread H.J. Lu
On Wed, Jun 22, 2011 at 12:36:57PM -0700, H.J. Lu wrote: > Hi, > > I just don't see how nonzero_bits1 can assume if pointers extend unsigned > and this is an addition or subtraction to a pointer in Pmode, all the bits > bove ptr_mode are known to be zero. We never run into it before x32 > since x

PATCH: PR rtl-optimization/49504: Invalid optimization for Pmode != ptr_mode

2011-06-22 Thread H.J. Lu
Hi, I just don't see how nonzero_bits1 can assume if pointers extend unsigned and this is an addition or subtraction to a pointer in Pmode, all the bits bove ptr_mode are known to be zero. We never run into it before x32 since x32 is the first such target. This patch deletes it. OK to install t