Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-20 Thread H.J. Lu
On Fri, Aug 17, 2012 at 2:42 AM, Chupin, Pavel V wrote: > Submitted patch here: https://android-review.googlesource.com/#/c/41705 > > -- Pavel > link.h has been added to AOSP. I am closing PR 54209. Thanks. -- H.J.

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-14 Thread H.J. Lu
On Tue, Aug 14, 2012 at 4:27 PM, Ian Lance Taylor wrote: > On Tue, Aug 14, 2012 at 3:47 PM, Maxim Kuvyrkov > wrote: > >> I think this patch will break MIPS Android build due to mismatch of >> ElfW(type) when _MIPS_SZPTR == 64. I think the right way to fix this is to >> make Bionic export link

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-14 Thread H.J. Lu
On Tue, Aug 14, 2012 at 3:47 PM, Maxim Kuvyrkov wrote: > On 15/08/2012, at 7:39 AM, H.J. Lu wrote: > >> On Tue, Aug 14, 2012 at 12:38 PM, H.J. Lu wrote: >>> On Thu, Aug 9, 2012 at 3:17 PM, Ian Lance Taylor wrote: On Thu, Aug 9, 2012 at 9:39 AM, H.J. Lu wrote: > > Bionic C library d

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-14 Thread Ian Lance Taylor
On Tue, Aug 14, 2012 at 3:47 PM, Maxim Kuvyrkov wrote: > I think this patch will break MIPS Android build due to mismatch of > ElfW(type) when _MIPS_SZPTR == 64. I think the right way to fix this is to > make Bionic export link.h or already-existing linker.h, but I differ to Ian > for final j

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-14 Thread Maxim Kuvyrkov
On 15/08/2012, at 7:39 AM, H.J. Lu wrote: > On Tue, Aug 14, 2012 at 12:38 PM, H.J. Lu wrote: >> On Thu, Aug 9, 2012 at 3:17 PM, Ian Lance Taylor wrote: >>> On Thu, Aug 9, 2012 at 9:39 AM, H.J. Lu wrote: Bionic C library doesn't provide link.h. >>> >>> Does Bionic provide dl_iterate_

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-14 Thread H.J. Lu
On Tue, Aug 14, 2012 at 12:38 PM, H.J. Lu wrote: > On Thu, Aug 9, 2012 at 3:17 PM, Ian Lance Taylor wrote: >> On Thu, Aug 9, 2012 at 9:39 AM, H.J. Lu wrote: >>> >>> Bionic C library doesn't provide link.h. >> >> Does Bionic provide dl_iterate_phdr? If it does, I'll just note in >> passing that

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-14 Thread H.J. Lu
On Thu, Aug 9, 2012 at 3:17 PM, Ian Lance Taylor wrote: > On Thu, Aug 9, 2012 at 9:39 AM, H.J. Lu wrote: >> >> Bionic C library doesn't provide link.h. > > Does Bionic provide dl_iterate_phdr? If it does, I'll just note in > passing that it would be straightforward to simply incorporate the > re

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-09 Thread Ian Lance Taylor
On Thu, Aug 9, 2012 at 4:01 PM, H.J. Lu wrote: > On Thu, Aug 9, 2012 at 3:17 PM, Ian Lance Taylor wrote: >> On Thu, Aug 9, 2012 at 9:39 AM, H.J. Lu wrote: >>> >>> Bionic C library doesn't provide link.h. >> >> Does Bionic provide dl_iterate_phdr? If it does, I'll just note in >> passing that it

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-09 Thread H.J. Lu
On Thu, Aug 9, 2012 at 3:17 PM, Ian Lance Taylor wrote: > On Thu, Aug 9, 2012 at 9:39 AM, H.J. Lu wrote: >> >> Bionic C library doesn't provide link.h. > > Does Bionic provide dl_iterate_phdr? If it does, I'll just note in > passing that it would be straightforward to simply incorporate the > re

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-09 Thread Ian Lance Taylor
On Thu, Aug 9, 2012 at 9:39 AM, H.J. Lu wrote: > > Bionic C library doesn't provide link.h. Does Bionic provide dl_iterate_phdr? If it does, I'll just note in passing that it would be straightforward to simply incorporate the required types and constants in unwind-dw2-fde-dip.c directly, and avo

RE: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-09 Thread Joseph S. Myers
On Thu, 9 Aug 2012, Fu, Chao-Ying wrote: > How about this patch? Just enable it for MIPS that provides link.h in > Android NDK. > Thanks a lot! Please don't put this sort of architecture conditional in an architecture-independent source file. In this case it should be fine for libgcc's con

RE: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-09 Thread Fu, Chao-Ying
> > Where does mips link.h come from? I didn't see it in AOSP > Bionic C library. > > -- > H.J. > It's from development/ndk/platforms/android-9/arch-mips/include/link.h from AOSP checkout. Regards, Chao-ying

Re: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-09 Thread H.J. Lu
On Thu, Aug 9, 2012 at 11:11 AM, Fu, Chao-Ying wrote: >> > Hi, >> > >> > Bionic C library doesn't provide link.h. This patch >> reverts revision >> > 186788: >> > >> > http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00740.html >> > >> > OK to install? >> > >> > Thanks. >> > >> > H.J. >> > --- >> > 2012-

RE: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-09 Thread Fu, Chao-Ying
> Hi, > > Bionic C library doesn't provide link.h. This patch reverts revision > 186788: > > http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00740.html > > OK to install? > > Thanks. > > H.J. > --- > 2012-08-09 H.J. Lu > > PR bootstrap/54209 > * unwind-dw2-fde-dip.c (USE_PT_GNU_EH_FR

RE: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-09 Thread Fu, Chao-Ying
> > Hi, > > > > Bionic C library doesn't provide link.h. This patch > reverts revision > > 186788: > > > > http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00740.html > > > > OK to install? > > > > Thanks. > > > > H.J. > > --- > > 2012-08-09 H.J. Lu > > > > PR bootstrap/54209 > > * unwin

PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86

2012-08-09 Thread H.J. Lu
Hi, Bionic C library doesn't provide link.h. This patch reverts revision 186788: http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00740.html OK to install? Thanks. H.J. --- 2012-08-09 H.J. Lu PR bootstrap/54209 * unwind-dw2-fde-dip.c (USE_PT_GNU_EH_FRAME): Don't define for