Re: PATCH: PR binutils/14526: c++filt is crashed on large files

2012-08-28 Thread Ian Lance Taylor
On Tue, Aug 28, 2012 at 5:55 PM, H.J. Lu wrote: > > Here is a patch. OK to install? > > Thanks. > > -- > H.J. > --- > * argv.c (dupargv): Replace malloc with xmalloc. Don't check > xmalloc return. > (buildargv): Likewise. > (expandargv): Don't check dupargv return

Re: PATCH: PR binutils/14526: c++filt is crashed on large files

2012-08-28 Thread H.J. Lu
On Tue, Aug 28, 2012 at 5:09 PM, Ian Lance Taylor wrote: > On Tue, Aug 28, 2012 at 11:33 AM, H.J. Lu wrote: >> >> buildargv uses alloca to allocate buffer, whose size may exceed stack >> limit. This patch replaces alloca with xmalloc/free. OK to install? >> >> Thanks. >> >> H.J. >> --- >>

Re: PATCH: PR binutils/14526: c++filt is crashed on large files

2012-08-28 Thread Ian Lance Taylor
On Tue, Aug 28, 2012 at 11:33 AM, H.J. Lu wrote: > > buildargv uses alloca to allocate buffer, whose size may exceed stack > limit. This patch replaces alloca with xmalloc/free. OK to install? > > Thanks. > > H.J. > --- > PR binutils/14526 > * argv.c (buildargv): Replace alloca w

PATCH: PR binutils/14526: c++filt is crashed on large files

2012-08-28 Thread H.J. Lu
Hi, buildargv uses alloca to allocate buffer, whose size may exceed stack limit. This patch replaces alloca with xmalloc/free. OK to install? Thanks. H.J. --- PR binutils/14526 * argv.c (buildargv): Replace alloca with xmalloc/free. diff --git a/libiberty/argv.c b/libiberty/ar