Re: Optimize handling of inline summaries

2019-11-14 Thread Martin Jambor
Hi, On Mon, Nov 04 2019, Jan Hubicka wrote: >> On 11/4/19 3:12 PM, Jan Hubicka wrote: >> > Martin, do you know why this flag was introduced? >> >> Hi. >> >> The flag is used in IPA CP: >> >> call_summary >> >> class edge_clone_summary >> { >> ... >> cgraph_edge *prev_clone; >> cgraph_edge

Re: Optimize handling of inline summaries

2019-11-05 Thread Martin Liška
On 11/4/19 8:09 PM, Jan Hubicka wrote: On 11/4/19 3:12 PM, Jan Hubicka wrote: Martin, do you know why this flag was introduced? Hi. The flag is used in IPA CP: call_summary class edge_clone_summary { ... cgraph_edge *prev_clone; cgraph_edge *next_clone; } I see, so it is there to c

Re: Optimize handling of inline summaries

2019-11-04 Thread Jan Hubicka
> On 11/4/19 3:12 PM, Jan Hubicka wrote: > > Martin, do you know why this flag was introduced? > > Hi. > > The flag is used in IPA CP: > > call_summary > > class edge_clone_summary > { > ... > cgraph_edge *prev_clone; > cgraph_edge *next_clone; > } I see, so it is there to collect chains

Re: Optimize handling of inline summaries

2019-11-04 Thread Martin Liška
On 11/4/19 3:12 PM, Jan Hubicka wrote: Martin, do you know why this flag was introduced? Hi. The flag is used in IPA CP: call_summary class edge_clone_summary { ... cgraph_edge *prev_clone; cgraph_edge *next_clone; } Apparently, IPA CP links all clones in one linked link. If you disabl

Optimize handling of inline summaries

2019-11-04 Thread Jan Hubicka
Hi, this patch turns edge growth cache into fast summary and fixes some fallout. I have noticed that we still use get_create on many places to access inline edge summary and turning them into gets uncovered furhter problems. I have added sanity check to estimate_calls_size_and_time that inlined e