Re: [PATCH v4] OpenMP: Generate SIMD clones for functions with "declare target"

2022-11-25 Thread Jakub Jelinek via Gcc-patches
On Mon, Nov 14, 2022 at 09:46:15PM -0700, Sandra Loosemore wrote: > --- a/gcc/omp-simd-clone.cc > +++ b/gcc/omp-simd-clone.cc > @@ -51,6 +51,210 @@ along with GCC; see the file COPYING3. If not see > #include "stringpool.h" > #include "attribs.h" > #include "omp-simd-clone.h" > +#include "omp-l

[PATCH v4] OpenMP: Generate SIMD clones for functions with "declare target"

2022-11-14 Thread Sandra Loosemore via Gcc-patches
piece yet. -SandraFrom 771be96d2dc7b8868ba06cf8ec6afe7a3337ac89 Mon Sep 17 00:00:00 2001 From: Sandra Loosemore Date: Tue, 15 Nov 2022 03:40:12 +0000 Subject: [PATCH] OpenMP: Generate SIMD clones for functions with "declare target" This patch causes the IPA simdclone pass to generate clones for functions with th

Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-27 Thread Sandra Loosemore
On 10/27/22 04:09, Thomas Schwinge wrote: Hi! On 2022-10-26T20:27:19-0600, Sandra Loosemore wrote: One of my test cases examines the .s output to make sure that the clones are emitted as local symbols and not global. I have not been able to find the symbol linkage information in any of the du

Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-27 Thread Thomas Schwinge
Hi! On 2022-10-26T20:27:19-0600, Sandra Loosemore wrote: > On 10/20/22 08:07, Jakub Jelinek wrote: >> Thus, IMHO it is exactly the pass_omp_simd_clone pass where you want to >> implement this auto-simdization discovery, guarded with >> #ifdef ACCEL_COMPILER and the new option (which means it will

Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-26 Thread Sandra Loosemore
On 10/20/22 08:07, Jakub Jelinek wrote: Thus, IMHO it is exactly the pass_omp_simd_clone pass where you want to implement this auto-simdization discovery, guarded with #ifdef ACCEL_COMPILER and the new option (which means it will be done only for gcn and not on the host right now). I'm running

Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-20 Thread Jakub Jelinek via Gcc-patches
On Sun, Oct 16, 2022 at 07:23:05PM -0600, Sandra Loosemore wrote: > My sense is that the first approach would be more straightforward than the > second one, and I am willing to continue to work on that. However, I think > I need some direction to get started, as I presently know nothing about > cg

Re: [PATCH v3] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-10-16 Thread Sandra Loosemore
in my new patch I arranged things so that the implicit clones are only created if there is also a call to the function found in an OMP loop (not just one caller anywhere). So this should be fixed now. New patch attached. Is this one OK for mainline? -Sandracommit eb1fe25b125cd153b2c661f1c54e61

Re: [PATCH v2] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-09-30 Thread Jakub Jelinek via Gcc-patches
On Wed, Sep 21, 2022 at 09:17:18PM -0600, Sandra Loosemore wrote: > On 9/14/22 12:12, Jakub Jelinek wrote: > > > If it is pure optimization thing and purely keyed on the definition, > > all the simd clones should be local to the TU, never exported from it. > > OK, here is a revised patch that add

[PATCH v2] Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-09-21 Thread Sandra Loosemore
fdb9a2162978b964863f351c814211dca8e9a3f Mon Sep 17 00:00:00 2001 From: Sandra Loosemore Date: Thu, 22 Sep 2022 02:16:42 +0000 Subject: [PATCH] OpenMP: Generate SIMD clones for functions with "declare target" This patch causes the IPA simdclone pass to generate clones for functions with the

Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-09-14 Thread Thomas Schwinge
Hi Sandra! Commenting on just one single item: On 2022-09-14T11:32:11-0600, Sandra Loosemore wrote: > --- a/gcc/omp-simd-clone.cc > +++ b/gcc/omp-simd-clone.cc > void > expand_simd_clones (struct cgraph_node *node) > { > - tree attr = lookup_attribute ("omp declare simd", > -

Re: OpenMP: Generate SIMD clones for functions with "declare target"

2022-09-14 Thread Jakub Jelinek via Gcc-patches
On Wed, Sep 14, 2022 at 11:32:11AM -0600, Sandra Loosemore wrote: > This patch is part of the ongoing effort to find more SIMD optimization > opportunities in OpenMP code. Here we are looking for functions that have > the "omp declare target" attribute that are also suitable candidates for > autom

OpenMP: Generate SIMD clones for functions with "declare target"

2022-09-14 Thread Sandra Loosemore
ed, 14 Sep 2022 00:20:25 + Subject: [PATCH] OpenMP: Generate SIMD clones for functions with "declare target" This patch causes the IPA simdclone pass to generate clones for functions with the "omp declare target" attribute as if they had "omp declare simd", pro