Re: [committed] Clean up Fortran OpenACC wait clause handling

2018-12-13 Thread Thomas Schwinge
Hi Julian! On Mon, 3 Dec 2018 16:02:23 +, Julian Brown wrote: > On Fri, 30 Nov 2018 21:48:20 +0100 > Thomas Schwinge wrote: > > commit 3e3de40a5ab21d72f08071a7a40120dd05608cc1 > > Author: tschwinge > > Date: Fri Nov 30 20:39:18 2018 + > > > >

Re: [committed] Clean up Fortran OpenACC wait clause handling

2018-12-03 Thread Julian Brown
On Fri, 30 Nov 2018 21:48:20 +0100 Thomas Schwinge wrote: > Hi! > > commit 3e3de40a5ab21d72f08071a7a40120dd05608cc1 > Author: tschwinge > Date: Fri Nov 30 20:39:18 2018 + > > Clean up Fortran OpenACC wait clause handling > > "wait

[committed] Clean up Fortran OpenACC wait clause handling

2018-11-30 Thread Thomas Schwinge
Hi! commit 3e3de40a5ab21d72f08071a7a40120dd05608cc1 Author: tschwinge Date: Fri Nov 30 20:39:18 2018 + Clean up Fortran OpenACC wait clause handling "wait" can be deduced from "wait_list". gcc/fortran/ * gfortran.h (struct gfc_

Re: OpenACC wait clause

2016-06-28 Thread Jakub Jelinek
On Mon, Jun 27, 2016 at 04:22:01PM -0700, Cesar Philippidis wrote: > + while (ret == MATCH_YES) > { > - if (cp->gang_static) > - return MATCH_ERROR; > + if (gfc_match (" static :") == MATCH_YES) > + { > + if (cp->gang_static) > + return M

Re: OpenACC wait clause

2016-06-27 Thread Cesar Philippidis
On 06/27/2016 12:23 PM, Jakub Jelinek wrote: > On Mon, Jun 27, 2016 at 11:36:26AM -0700, Cesar Philippidis wrote: >> @@ -630,9 +653,10 @@ gfc_match_omp_clauses (gfc_omp_clauses **cp, uint64_t >> mask, >> { >>gfc_omp_clauses *c = gfc_get_omp_clauses (); >>locus old_loc; >> + bool seen_er

Re: OpenACC wait clause

2016-06-27 Thread Jakub Jelinek
On Mon, Jun 27, 2016 at 11:36:26AM -0700, Cesar Philippidis wrote: > With that aside, this patch should correct the issues you pointed out. > gfc_match_omp_clauses now uses a common function to parse the gang, > worker and vector clauses. Also, this patch takes extra care with > MATCH_ERRORs when p

Re: OpenACC wait clause

2016-06-27 Thread Cesar Philippidis
On 06/24/2016 08:53 AM, Jakub Jelinek wrote: > On Fri, Jun 24, 2016 at 08:42:49AM -0700, Cesar Philippidis wrote: @@ -1328,7 +1328,8 @@ gfc_match_omp_clauses (gfc_omp_clauses **cp, uint64_t mask, && gfc_match ("wait") == MATCH_YES) { c->wait = true

Re: OpenACC wait clause

2016-06-24 Thread Jakub Jelinek
On Fri, Jun 24, 2016 at 08:42:49AM -0700, Cesar Philippidis wrote: > >> @@ -1328,7 +1328,8 @@ gfc_match_omp_clauses (gfc_omp_clauses **cp, > >> uint64_t mask, > >> && gfc_match ("wait") == MATCH_YES) > >>{ > >> c->wait = true; > >> -match_oacc_expr_list (" (", &c-

Re: OpenACC wait clause

2016-06-24 Thread Cesar Philippidis
On 06/17/2016 07:34 AM, Jakub Jelinek wrote: > On Thu, Jun 16, 2016 at 08:22:29PM -0700, Cesar Philippidis wrote: >> --- a/gcc/fortran/openmp.c >> +++ b/gcc/fortran/openmp.c >> @@ -677,7 +677,6 @@ gfc_match_omp_clauses (gfc_omp_clauses **cp, uint64_t >> mask, >>&& gfc_match ("async") =

Re: OpenACC wait clause

2016-06-17 Thread Jakub Jelinek
On Thu, Jun 16, 2016 at 08:22:29PM -0700, Cesar Philippidis wrote: > --- a/gcc/fortran/openmp.c > +++ b/gcc/fortran/openmp.c > @@ -677,7 +677,6 @@ gfc_match_omp_clauses (gfc_omp_clauses **cp, uint64_t > mask, > && gfc_match ("async") == MATCH_YES) > { > c->async =

Re: OpenACC wait clause

2016-06-16 Thread Cesar Philippidis
On 06/07/2016 08:02 AM, Jakub Jelinek wrote: > On Tue, Jun 07, 2016 at 08:01:10AM -0700, Cesar Philippidis wrote: >> On 06/07/2016 04:13 AM, Jakub Jelinek wrote: >> >>> I've noticed >>> if ((mask & OMP_CLAUSE_WAIT) >>> && !c->wait >>> && gfc_match ("wait") == M

Re: OpenACC wait clause

2016-06-07 Thread Jakub Jelinek
On Tue, Jun 07, 2016 at 08:01:10AM -0700, Cesar Philippidis wrote: > On 06/07/2016 04:13 AM, Jakub Jelinek wrote: > > > I've noticed > > if ((mask & OMP_CLAUSE_WAIT) > > && !c->wait > > && gfc_match ("wait") == MATCH_YES) > > { > > c-

Re: OpenACC wait clause

2016-06-07 Thread Cesar Philippidis
On 06/07/2016 04:13 AM, Jakub Jelinek wrote: > I've noticed > if ((mask & OMP_CLAUSE_WAIT) > && !c->wait > && gfc_match ("wait") == MATCH_YES) > { > c->wait = true; > match_oacc_expr_list (" (", &c->wait_list, false); >

OpenACC wait clause

2016-06-07 Thread Jakub Jelinek
Hi! I've noticed if ((mask & OMP_CLAUSE_WAIT) && !c->wait && gfc_match ("wait") == MATCH_YES) { c->wait = true; match_oacc_expr_list (" (", &c->wait_list, false); continue; } which looks just w