Re: ORDERED_EXPR in invert_tree_comparison

2012-08-02 Thread Nathan Froyd
On Thu, Aug 02, 2012 at 05:20:24PM +0200, Marc Glisse wrote: > On Thu, 2 Aug 2012, Nathan Froyd wrote: > >>PR tree-optimization/53805 > >>* fold-const.c (invert_tree_comparison): Do invert ORDERED_EXPR and > >>UNORDERED_EXPR for floating point. > > > >Minor protest about the ChangeLog:

Re: ORDERED_EXPR in invert_tree_comparison

2012-08-02 Thread Marc Glisse
On Thu, 2 Aug 2012, Nathan Froyd wrote: On Thu, Aug 02, 2012 at 02:48:08PM +0200, Marc Glisse wrote: I am redoing the bootstrap+regtest, then I'll commit if I don't hear protests about the testcase. gcc/ChangeLog 2012-06-15 Marc Glisse PR tree-optimization/53805 * fold-cons

Re: ORDERED_EXPR in invert_tree_comparison

2012-08-02 Thread Nathan Froyd
On Thu, Aug 02, 2012 at 02:48:08PM +0200, Marc Glisse wrote: > I am redoing the bootstrap+regtest, then I'll commit if I don't hear > protests about the testcase. > > gcc/ChangeLog > 2012-06-15 Marc Glisse > > PR tree-optimization/53805 > * fold-const.c (invert_tree_comparison): Do

Re: ORDERED_EXPR in invert_tree_comparison

2012-08-02 Thread Richard Guenther
On Thu, Aug 2, 2012 at 2:48 PM, Marc Glisse wrote: > On Thu, 2 Aug 2012, Richard Guenther wrote: > >> On Wed, Aug 1, 2012 at 9:21 PM, Marc Glisse wrote: >>> >>> Hello, >>> >>> an opinion on this? >>> >>> (I just noticed: I'll update the list in the comment visible at the top >>> of >>> the patch

Re: ORDERED_EXPR in invert_tree_comparison

2012-08-02 Thread Marc Glisse
On Thu, 2 Aug 2012, Richard Guenther wrote: On Wed, Aug 1, 2012 at 9:21 PM, Marc Glisse wrote: Hello, an opinion on this? (I just noticed: I'll update the list in the comment visible at the top of the patch if this gets in). It looks ok to me but I am no floating-point expert. Can you add

Re: ORDERED_EXPR in invert_tree_comparison

2012-08-02 Thread Richard Guenther
On Wed, Aug 1, 2012 at 9:21 PM, Marc Glisse wrote: > Hello, > > an opinion on this? > > (I just noticed: I'll update the list in the comment visible at the top of > the patch if this gets in). It looks ok to me but I am no floating-point expert. Can you add a testcase? Ok with that change. Tha

Re: ORDERED_EXPR in invert_tree_comparison

2012-08-01 Thread Marc Glisse
Hello, an opinion on this? (I just noticed: I'll update the list in the comment visible at the top of the patch if this gets in). On Thu, 19 Jul 2012, Marc Glisse wrote: Hello, the simple patch below passes the testsuite after a c,c++ bootstrap without new regressions. Note however that

ORDERED_EXPR in invert_tree_comparison

2012-07-19 Thread Marc Glisse
Hello, the simple patch below passes the testsuite after a c,c++ bootstrap without new regressions. Note however that #include int f(double a, double b){ return (!isunordered(a,b))&&(ais then optimized by ifcombine to "return (athe absence of -fno-trapping-math. I don't know if there are wa