Re: ODR merging and implicit typedefs

2015-05-22 Thread Eric Botcazou
> I will take a look if I can improve type_in_anonymous_namepsace somehow. So > Ada produces TYPE_DECL with DECL_ABSTRACT that do have TYPE_STUB_DECL with > TREE_PUBLIC NULL I suppose. Do you mean DECL_ARTIFICIAL instead of DECL_ABSTRACT? If so, presumably, yes, why wouldn't it do that? That s

Re: ODR merging and implicit typedefs

2015-05-20 Thread Jan Hubicka
> > I bootstrapped/regtested on x86_64-linux the patch bellow. If it will work > > for Firefox and Chrome I will go ahead with it at least temporarily. > > Really? This introduced a LTO failure in the gnat.dg testsuite: > > FAIL: gnat.dg/lto8.adb (internal compiler error) > FAIL: gnat.dg/lto8.ad

Re: ODR merging and implicit typedefs

2015-05-20 Thread Eric Botcazou
> I bootstrapped/regtested on x86_64-linux the patch bellow. If it will work > for Firefox and Chrome I will go ahead with it at least temporarily. Really? This introduced a LTO failure in the gnat.dg testsuite: FAIL: gnat.dg/lto8.adb (internal compiler error) FAIL: gnat.dg/lto8.adb (test for ex

Re: ODR merging and implicit typedefs

2015-05-19 Thread Jan Hubicka
> On 05/19/2015 01:33 PM, Jan Hubicka wrote: > >I tracked down that those are implicit typedef created by > >create_implicit_typedef. > >My patch made them no longer anonymous that in turn triggers the bogus > >diagnostics. > >I do not think it is fully correct though - those types are not anonym

Re: ODR merging and implicit typedefs

2015-05-19 Thread Jason Merrill
On 05/19/2015 01:33 PM, Jan Hubicka wrote: I tracked down that those are implicit typedef created by create_implicit_typedef. My patch made them no longer anonymous that in turn triggers the bogus diagnostics. I do not think it is fully correct though - those types are not anonymous. Hmm? Th

Re: ODR merging and implicit typedefs

2015-05-19 Thread Markus Trippelsdorf
On 2015.05.19 at 19:33 +0200, Jan Hubicka wrote: > > Jason, > I just noticed that there are bogus ODR violation warnings during > LTO-bootstrap > (that breaks -Werror builds). It was caused by my work-around for > type_in_anonymous_namespace > for the issue discussed in: > https://gcc.gnu.org/m

ODR merging and implicit typedefs

2015-05-19 Thread Jan Hubicka
Jason, I just noticed that there are bogus ODR violation warnings during LTO-bootstrap (that breaks -Werror builds). It was caused by my work-around for type_in_anonymous_namespace for the issue discussed in: https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01245.html (i.e. the TYPE_STUB_DECL disuc