Re: Minor regression due to recent IRA changes

2020-03-08 Thread Jeff Law
On Sun, 2020-03-08 at 15:53 +0900, Oleg Endo wrote: > On Thu, 2020-03-05 at 08:51 -0700, Jeff Law wrote: > > FWIW I've got an sh4/sh4eb bootstrap and regression test running with > > HONOR_REG_ALLOC_ORDER defined. As Vlad mentioned, that may be a > > viable workaround. > > > > I've had a look at

Re: Minor regression due to recent IRA changes

2020-03-07 Thread Oleg Endo
On Thu, 2020-03-05 at 08:51 -0700, Jeff Law wrote: > > FWIW I've got an sh4/sh4eb bootstrap and regression test running with > HONOR_REG_ALLOC_ORDER defined. As Vlad mentioned, that may be a > viable workaround. > I've had a look at the good old CSiBE code size results and poked at some of the

Re: Minor regression due to recent IRA changes

2020-03-05 Thread Jeff Law
On Sun, 2020-03-01 at 10:37 +0900, Oleg Endo wrote: > On Sat, 2020-02-29 at 12:35 -0700, Jeff Law wrote: > > Yup. That was roughly what I was thinking and roughly the worry I had with > > trying to squash out the quality regressions. But it may ultimately be the > > only way to really resolve the

Re: Minor regression due to recent IRA changes

2020-03-02 Thread Vladimir Makarov
On 2020-03-02 4:34 a.m., Richard Biener wrote: One could also simply pessimize R0 for RA via either an existing mechanism or a new target hook ... Yes, it could be a good strategy.  I'd recommend to try HONOR_REG_ALLOC_ORDER first with/without LRA. If it does not work I am ready to accept

Re: Minor regression due to recent IRA changes

2020-03-02 Thread Vladimir Makarov
On 2020-02-29 10:47 a.m., Jeff Law wrote: On Sun, 2020-03-01 at 00:43 +0900, Oleg Endo wrote: This could well be a target issue. I haven't tried to debug it. If it's a target issue, I'm fully comfortable punting it to the SH folks for resolving. The R0_REGS spill failure is a general proble

Re: Minor regression due to recent IRA changes

2020-03-02 Thread Richard Biener
On Sat, Feb 29, 2020 at 8:35 PM Jeff Law wrote: > > On Sun, 2020-03-01 at 01:47 +0900, Oleg Endo wrote: > > On Sat, 2020-02-29 at 09:38 -0700, Jeff Law wrote: > > > It really would have just been a workaround for some of the R0 issues > > > anyway. > > > I think at its core R0 on the SH probably n

Re: Minor regression due to recent IRA changes

2020-02-29 Thread Oleg Endo
On Sat, 2020-02-29 at 12:35 -0700, Jeff Law wrote: > > Yup. That was roughly what I was thinking and roughly the worry I had with > trying to squash out the quality regressions. But it may ultimately be the > only way to really resolve these issues. Another idea would be to let RA see R0, but i

Re: Minor regression due to recent IRA changes

2020-02-29 Thread Jeff Law
On Sun, 2020-03-01 at 01:47 +0900, Oleg Endo wrote: > On Sat, 2020-02-29 at 09:38 -0700, Jeff Law wrote: > > It really would have just been a workaround for some of the R0 issues > > anyway. > > I think at its core R0 on the SH probably needs to be treated more like a > > temporary rather than a g

Re: Minor regression due to recent IRA changes

2020-02-29 Thread Oleg Endo
On Sat, 2020-02-29 at 09:38 -0700, Jeff Law wrote: > > It really would have just been a workaround for some of the R0 issues anyway. > I think at its core R0 on the SH probably needs to be treated more like a > temporary rather than a general register. But that's probably a huge change, > both i

Re: Minor regression due to recent IRA changes

2020-02-29 Thread Jeff Law
On Sun, 2020-03-01 at 01:06 +0900, Oleg Endo wrote: > On Sat, 2020-02-29 at 08:57 -0700, Jeff Law wrote: > > > It could open a can of worms. Off the top of my head, R0 is used to > > > hold the function return value, and R0:R1 to return structs with sizeof > > > > 4 bytes. So if DImode is allocat

Re: Minor regression due to recent IRA changes

2020-02-29 Thread Oleg Endo
On Sat, 2020-02-29 at 08:57 -0700, Jeff Law wrote: > > > It could open a can of worms. Off the top of my head, R0 is used to > > hold the function return value, and R0:R1 to return structs with sizeof > > > 4 bytes. So if DImode is allocated to R0, it implicitly uses R0:R1, > > > > AFAIR, doesn

Re: Minor regression due to recent IRA changes

2020-02-29 Thread Jeff Law
On Sun, 2020-03-01 at 00:55 +0900, Oleg Endo wrote: > On Sat, 2020-02-29 at 08:47 -0700, Jeff Law wrote: > > It's almost certainly the case that the recent IRA changes are going to > > stress > > R0 more. If I'm reading what Vlad did correctly, one of the tie-breakers > > its > > using now is to c

Re: Minor regression due to recent IRA changes

2020-02-29 Thread Oleg Endo
On Sat, 2020-02-29 at 08:47 -0700, Jeff Law wrote: > > It's almost certainly the case that the recent IRA changes are going to stress > R0 more. If I'm reading what Vlad did correctly, one of the tie-breakers its > using now is to choose the lowest numbered register when all else is equal. > So

Re: Minor regression due to recent IRA changes

2020-02-29 Thread Jeff Law
On Sun, 2020-03-01 at 00:43 +0900, Oleg Endo wrote: > > > This could well be a target issue. I haven't tried to debug it. If > > it's a > > target issue, I'm fully comfortable punting it to the SH folks for > > resolving. > > The R0_REGS spill failure is a general problem, in particular with ol

Re: Minor regression due to recent IRA changes

2020-02-29 Thread Oleg Endo
On Fri, 2020-02-28 at 13:24 -0700, Jeff Law wrote: > This change: > > > commit 3133bed5d0327e8a9cd0a601b7ecdb9de4fc825d > > Author: Vladimir N. Makarov > > Date: Sun Feb 23 16:20:05 2020 -0500 > > > > Changing cost propagation and ordering colorable bucket > > heuristics for > > PR93564. >

Minor regression due to recent IRA changes

2020-02-28 Thread Jeff Law
This change: > commit 3133bed5d0327e8a9cd0a601b7ecdb9de4fc825d > Author: Vladimir N. Makarov > Date: Sun Feb 23 16:20:05 2020 -0500 > > Changing cost propagation and ordering colorable bucket heuristics for > PR93564. > > 2020-02-23 Vladimir Makarov > > PR rtl-