On 05/20/2017 02:27 AM, DJ Delorie wrote:
>
> Pedro Alves writes:
>> That sounds to me like the root issue that should be fixed,
>> so that these fallback definitions don't come into into play at all.
>> I.e., why isn't HAVE_ENVIRON_DECL defined on mingw when
>> setenv.o is built? Sounds like a
> From: DJ Delorie
> Cc: pal...@redhat.com, gcc-patches@gcc.gnu.org, gdb-patc...@sourceware.org
> Date: Sat, 20 May 2017 02:16:14 -0400
>
> Eli Zaretskii writes:
> > My problem is, I don't have a GCC repository, so doing the above means
>
> In this case, a gdb repo would have sufficed.
Thanks,
Eli Zaretskii writes:
> My problem is, I don't have a GCC repository, so doing the above means
In this case, a gdb repo would have sufficed.
> IOW, not everyone who reports a problem can necessarily provide a
> patch. The fact that you know too much about my abilities in other
> projects doesn
> From: DJ Delorie
> Cc: gcc-patches@gcc.gnu.org, gdb-patc...@sourceware.org
> Date: Fri, 19 May 2017 21:25:56 -0400
>
> Fix committed.
Thanks!
Pedro, how do we make this propagated to the GDB repository?
> As Pedro noted, the correct way to request a change is
> to make the change in your loc
Pedro Alves writes:
> That sounds to me like the root issue that should be fixed,
> so that these fallback definitions don't come into into play at all.
> I.e., why isn't HAVE_ENVIRON_DECL defined on mingw when
> setenv.o is built? Sounds like a decl check is missing
> in configure.ac.
environ
Fix committed. As Pedro noted, the correct way to request a change is
to make the change in your local checked out repo, and run "svn diff"
(or "git diff"). That makes sure that the fix is what you intended, and
that you don't have other unexpected changes (especially in regenerated
files, like
> Cc: gdb-patc...@sourceware.org
> From: Pedro Alves
> Date: Fri, 19 May 2017 16:51:30 +0100
>
> So again there's a system header that defines the symbol
> but for some reason libiberty still wants to declare/define
> it is if it weren't?
Yes. AFAICS, libiberty's configure script doesn't check
On 05/08/2017 04:25 PM, Eli Zaretskii wrote:
> When compiling libiberty (as part of GDB) with MinGW on MS-Windows, I
> see the following warning:
>
> gcc -c -DHAVE_CONFIG_H -O2 -gdwarf-4 -g3 -D__USE_MINGW_ACCESS -I.
> -I./../include -W -Wall -Wwrite-strings -Wc++-compat -Wstrict-prototype
When compiling libiberty (as part of GDB) with MinGW on MS-Windows, I
see the following warning:
gcc -c -DHAVE_CONFIG_H -O2 -gdwarf-4 -g3 -D__USE_MINGW_ACCESS -I.
-I./../include -W -Wall -Wwrite-strings -Wc++-compat -Wstrict-prototypes
-pedantic -D_GNU_SOURCE ./setenv.c -o setenv.o
