Re: Merge stores/loads in modref summaries

2021-08-26 Thread Jeff Law via Gcc-patches
On 8/26/2021 11:10 AM, Jan Hubicka wrote: commit f075b8c5adcf9cb6336563c472c8d624c54184db Author: Jan Hubicka Date: Thu Aug 26 15:33:56 2021 +0200 Fix off-by-one error in try_merge_with gcc/ChangeLog: * ipa-modref-tree.h (modref_ref_node::verify): New member

Re: Merge stores/loads in modref summaries

2021-08-26 Thread Jeff Law via Gcc-patches
On 8/26/2021 11:10 AM, Jan Hubicka wrote: commit f075b8c5adcf9cb6336563c472c8d624c54184db Author: Jan Hubicka Date: Thu Aug 26 15:33:56 2021 +0200 Fix off-by-one error in try_merge_with gcc/ChangeLog: * ipa-modref-tree.h (modref_ref_node::verify): New member

Re: Merge stores/loads in modref summaries

2021-08-26 Thread Jan Hubicka
> > commit f075b8c5adcf9cb6336563c472c8d624c54184db > Author: Jan Hubicka > Date: Thu Aug 26 15:33:56 2021 +0200 > > Fix off-by-one error in try_merge_with > > gcc/ChangeLog: > > * ipa-modref-tree.h (modref_ref_node::verify): New member > functoin. >

Re: Merge stores/loads in modref summaries

2021-08-26 Thread Jeff Law via Gcc-patches
On 8/26/2021 9:27 AM, H.J. Lu via Gcc-patches wrote: On Thu, Aug 26, 2021 at 2:49 AM Jan Hubicka wrote: On 8/26/21 10:33, Christophe Lyon via Gcc-patches wrote: Can you have a look? Please create a PR for it. I have fix, so perhaps there is no need for PR :) I am testing the following - t

Re: Merge stores/loads in modref summaries

2021-08-26 Thread H.J. Lu via Gcc-patches
On Thu, Aug 26, 2021 at 2:49 AM Jan Hubicka wrote: > > > On 8/26/21 10:33, Christophe Lyon via Gcc-patches wrote: > > > Can you have a look? > > > > Please create a PR for it. > I have fix, so perhaps there is no need for PR :) > I am testing the following - the problem was that try_merge_with mis

Re: Merge stores/loads in modref summaries

2021-08-26 Thread Jan Hubicka
> On 8/26/21 10:33, Christophe Lyon via Gcc-patches wrote: > > Can you have a look? > > Please create a PR for it. I have fix, so perhaps there is no need for PR :) I am testing the following - the problem was that try_merge_with missed some merges because how unoredered_remove handles the vector.

Re: Merge stores/loads in modref summaries

2021-08-26 Thread Jan Hubicka
> > This patch is causing ICEs on arm: > FAIL: g++.dg/torture/pr89303.C -O1 (internal compiler error) > FAIL: g++.dg/torture/pr89303.C -O1 (test for excess errors) It happens on 32bit arches only it seems. For some reason we end up merging access: Parm 0 param offset:12 offset:0 size:96

Re: Merge stores/loads in modref summaries

2021-08-26 Thread Martin Liška
On 8/26/21 10:33, Christophe Lyon via Gcc-patches wrote: Can you have a look? Please create a PR for it. Thanks, Martin

Re: Merge stores/loads in modref summaries

2021-08-26 Thread Christophe Lyon via Gcc-patches
Hi, On Wed, Aug 25, 2021 at 7:58 PM Jan Hubicka wrote: > Hi, > this patch adds logic needed to merge neighbouring accesses in ipa-modref > summaries. This helps analyzing array initializers and similar code. It > is > bit of work, since it breaks the fact that modref tree makes a good > latti

Merge stores/loads in modref summaries

2021-08-25 Thread Jan Hubicka
Hi, this patch adds logic needed to merge neighbouring accesses in ipa-modref summaries. This helps analyzing array initializers and similar code. It is bit of work, since it breaks the fact that modref tree makes a good lattice for dataflow: the access ranges can be extended indefinitely. For t