Re: Merge profiles of duplicated COMDAT functions

2013-08-30 Thread Jan Hubicka
> Jan Hubicka writes: > > > > Now for longer term, we want to make function CFGs independent of gimple > > body > > and we want to decide on instrumentation at linktime, so we won't require > > user > > to rebuild with -fprofile-use, just relink. I plan to work on this, but > > not for 4.9. >

Re: Merge profiles of duplicated COMDAT functions

2013-08-30 Thread Andi Kleen
Jan Hubicka writes: > > Now for longer term, we want to make function CFGs independent of gimple body > and we want to decide on instrumentation at linktime, so we won't require user > to rebuild with -fprofile-use, just relink. I plan to work on this, but > not for 4.9. It may be already obso

Re: Merge profiles of duplicated COMDAT functions

2013-08-30 Thread Jan Hubicka
> > Please instead remove this assert and put the checking into > tree-cfg.c:verify_gimple_label where it should need no special-casing > on cgraph_state. > > Otherwise the non-profile bits look ok. OK, will do. Thank you! Honza

Re: Merge profiles of duplicated COMDAT functions

2013-08-30 Thread Richard Biener
On Fri, 30 Aug 2013, Jan Hubicka wrote: > Hi, > this patch makes COMDAT profiles right with LTO. (made jointly with Martin > Liska) > > To recap the issue: COMDAT functions are produced many times. Each copy gets > its own set of counters and depending on inlining and linker decision, one > or

Merge profiles of duplicated COMDAT functions

2013-08-30 Thread Jan Hubicka
Hi, this patch makes COMDAT profiles right with LTO. (made jointly with Martin Liska) To recap the issue: COMDAT functions are produced many times. Each copy gets its own set of counters and depending on inlining and linker decision, one or more of copies of a given COMDAT function will get exe