Re: Improve std::rotate usages

2018-08-07 Thread Jonathan Wakely
On 27/05/18 19:25 +0200, François Dumont wrote: Still no chance to review it ? I'd like this one to go in before submitting other algo related patches.     * include/bits/stl_algo.h     (__rotate(_Ite, _Ite, _Ite, forward_iterator_tag))     (__rotate(_Ite, _Ite, _Ite, bidirectional_iterator_tag

Re: Improve std::rotate usages

2018-07-24 Thread François Dumont
Ping. On 08/06/2018 07:54, François Dumont wrote: Gentle reminder. On 27/05/2018 19:25, François Dumont wrote: Still no chance to review it ? I'd like this one to go in before submitting other algo related patches.     * include/bits/stl_algo.h     (__rotate(_Ite, _Ite, _Ite, forward_iterato

Re: Improve std::rotate usages

2018-06-12 Thread Jonathan Wakely
On 12/06/18 22:39 +0200, François Dumont wrote: I'm struggling having a validation for this patch. As it is a trivial one and to not bother you I plan to commit it tomorrow if not told otherwise. No, please wait for review.

Re: Improve std::rotate usages

2018-06-12 Thread François Dumont
I'm struggling having a validation for this patch. As it is a trivial one and to not bother you I plan to commit it tomorrow if not told otherwise. François On 08/06/2018 07:54, François Dumont wrote: Gentle reminder. On 27/05/2018 19:25, François Dumont wrote: Still no chance to review

Re: Improve std::rotate usages

2018-06-07 Thread François Dumont
Gentle reminder. On 27/05/2018 19:25, François Dumont wrote: Still no chance to review it ? I'd like this one to go in before submitting other algo related patches.     * include/bits/stl_algo.h     (__rotate(_Ite, _Ite, _Ite, forward_iterator_tag))     (__rotate(_Ite, _Ite, _Ite, bidirectiona

Re: Improve std::rotate usages

2018-05-27 Thread François Dumont
Still no chance to review it ? I'd like this one to go in before submitting other algo related patches.     * include/bits/stl_algo.h     (__rotate(_Ite, _Ite, _Ite, forward_iterator_tag))     (__rotate(_Ite, _Ite, _Ite, bidirectional_iterator_tag))     (__rotate(_Ite, _Ite, _Ite, random_access_

Re: Improve std::rotate usages

2018-05-14 Thread François Dumont
Any feedback regarding this patch ? On 02/05/2018 07:26, François Dumont wrote: Hi     std::rotate already returns the expected iterator so there is no need for calls to std::advance/std::distance. Tested under Linux x86_64, ok to commit ? François

Improve std::rotate usages

2018-05-01 Thread François Dumont
Hi     std::rotate already returns the expected iterator so there is no need for calls to std::advance/std::distance. Tested under Linux x86_64, ok to commit ? François diff --git a/libstdc++-v3/include/bits/stl_algo.h b/libstdc++-v3/include/bits/stl_algo.h index e10a692..9c1b2d4 100644 ---