Re: IRA costs tweaks, PR 56069

2016-06-23 Thread Jeff Law
On 04/27/2016 05:33 AM, Bernd Schmidt wrote: On 04/27/2016 06:02 AM, Jeff Law wrote: AFAICT the sra-1.c expects to see the incremented value and I'm at a loss to understand what's really going on here. Can you give more details? Yeah, maybe my first impression wasn't very accurate. When I tr

Re: IRA costs tweaks, PR 56069

2016-04-27 Thread Bernd Schmidt
On 04/27/2016 06:02 AM, Jeff Law wrote: AFAICT the sra-1.c expects to see the incremented value and I'm at a loss to understand what's really going on here. Can you give more details? Yeah, maybe my first impression wasn't very accurate. When I try to run gdb manually, it just crashes: (gdb)

Re: IRA costs tweaks, PR 56069

2016-04-26 Thread Jeff Law
On 04/25/2016 03:11 AM, Bernd Schmidt wrote: On 03/02/2016 10:53 PM, Vladimir Makarov wrote: The patch is ok for me. But I'd wait for GCC7. People are sensitive to their code performance degradation. Even in most cases the patch improves performance, in some case it can worsen code and peop

Re: IRA costs tweaks, PR 56069

2016-04-26 Thread Jeff Law
On 03/02/2016 02:53 PM, Vladimir Makarov wrote: The overall effect of this patch seems to be fairly minimal in practice, which is slightly disappointing. On the whole, it seems to be a very slight net positive, with few instances where we generate additional instructions. I am just speculating

Re: IRA costs tweaks, PR 56069

2016-04-25 Thread Bernd Schmidt
On 03/02/2016 10:53 PM, Vladimir Makarov wrote: The patch is ok for me. But I'd wait for GCC7. People are sensitive to their code performance degradation. Even in most cases the patch improves performance, in some case it can worsen code and people might fill new PRs after such change. I'v

Re: IRA costs tweaks, PR 56069

2016-03-07 Thread Richard Sandiford
Bernd Schmidt writes: > On 03/02/2016 10:53 PM, Vladimir Makarov wrote: >>> 2. update_costs_from_allocno records a cost update not just for the >>> initial allocno, but for each of the visited ones. I can sort of see >>> an argument for doing that (let's say if you assign an allocno in the >>> mid

Re: IRA costs tweaks, PR 56069

2016-03-03 Thread Bernd Schmidt
On 03/02/2016 10:53 PM, Vladimir Makarov wrote: 2. update_costs_from_allocno records a cost update not just for the initial allocno, but for each of the visited ones. I can sort of see an argument for doing that (let's say if you assign an allocno in the middle of a copy chain you'd want the tail

Re: IRA costs tweaks, PR 56069

2016-03-02 Thread Vladimir Makarov
On 03/02/2016 12:29 PM, Bernd Schmidt wrote: I had a look at the costs issues in this PR. I think I've found a fair number of bugs, but fixing those alone doesn't solve the issue; one additional tweak is needed. As for the bugs, they are primarily in the mechanism of recording cost updates an

IRA costs tweaks, PR 56069

2016-03-02 Thread Bernd Schmidt
I had a look at the costs issues in this PR. I think I've found a fair number of bugs, but fixing those alone doesn't solve the issue; one additional tweak is needed. As for the bugs, they are primarily in the mechanism of recording cost updates and restoring them. When adjusting costs for pre