On Fri, Feb 2, 2018 at 10:24 AM, Rainer Orth
wrote:
>
>>> the new test FAILs on Solaris 10, sparc and x86 (only, 11 is fine) at
>>> all optimization levels:
>>>
>>> +FAIL: go.go-torture/execute/printnil.go execution, -O0
>>> +FAIL: go.go-torture/execute/printnil.go execution, -O1
>>> +FAIL: go.g
Hi Ian,
>> the new test FAILs on Solaris 10, sparc and x86 (only, 11 is fine) at
>> all optimization levels:
>>
>> +FAIL: go.go-torture/execute/printnil.go execution, -O0
>> +FAIL: go.go-torture/execute/printnil.go execution, -O1
>> +FAIL: go.go-torture/execute/printnil.go execution, -O2
>> +FA
On Fri, Feb 2, 2018 at 6:14 AM, Rainer Orth
wrote:
>
>> This patch to the Go frontend changes value methods to always check
>> that the pointer they are passed is not nil. We already dereference
>> the pointer to copy the value, but if the method does not use the
>> value then the pointer derefe
Hi Ian,
> This patch to the Go frontend changes value methods to always check
> that the pointer they are passed is not nil. We already dereference
> the pointer to copy the value, but if the method does not use the
> value then the pointer dereference may be optimized away. Do an
> explicit nil
This patch to the Go frontend changes value methods to always check
that the pointer they are passed is not nil. We already dereference
the pointer to copy the value, but if the method does not use the
value then the pointer dereference may be optimized away. Do an
explicit nil check so that we g
