Re: Generalize gimple_val_nonnegative_real_p

2015-10-08 Thread Richard Biener
On Thu, Oct 8, 2015 at 12:10 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Oct 5, 2015 at 5:02 PM, Richard Sandiford >> wrote: >>> The upcoming patch to move sqrt and cbrt simplifications to match.pd >>> caused a regression because the (abs @0)->@0 simplification didn't >>> tr

Re: Generalize gimple_val_nonnegative_real_p

2015-10-08 Thread Richard Sandiford
Richard Biener writes: > On Mon, Oct 5, 2015 at 5:02 PM, Richard Sandiford > wrote: >> The upcoming patch to move sqrt and cbrt simplifications to match.pd >> caused a regression because the (abs @0)->@0 simplification didn't >> trigger for: >> >> (abs (convert (abs X))) >> >> The simplificat

Re: Generalize gimple_val_nonnegative_real_p

2015-10-06 Thread Richard Biener
On Mon, Oct 5, 2015 at 5:02 PM, Richard Sandiford wrote: > The upcoming patch to move sqrt and cbrt simplifications to match.pd > caused a regression because the (abs @0)->@0 simplification didn't > trigger for: > > (abs (convert (abs X))) > > The simplification is based on tree_expr_nonnegati

Generalize gimple_val_nonnegative_real_p

2015-10-05 Thread Richard Sandiford
The upcoming patch to move sqrt and cbrt simplifications to match.pd caused a regression because the (abs @0)->@0 simplification didn't trigger for: (abs (convert (abs X))) The simplification is based on tree_expr_nonnegative_p, which is pretty weak for gimple (it gives up if it sees an SSA_N