Re: GOMP_offload_register

2015-07-13 Thread Nathan Sidwell
On 07/13/15 09:49, Ilya Verbin wrote: On Mon, Jul 13, 2015 at 09:42:50 -0400, Nathan Sidwell wrote: GOMP_offload_register's target data argument is 'void *'. Is there any reason it shouldn't be 'const void *'? It would seem to me that that would be better? (a cursory look at i386/intelmic-mko

Re: GOMP_offload_register

2015-07-13 Thread Ilya Verbin
On Mon, Jul 13, 2015 at 09:42:50 -0400, Nathan Sidwell wrote: > GOMP_offload_register's target data argument is 'void *'. Is there > any reason it shouldn't be 'const void *'? It would seem to me that > that would be better? > > (a cursory look at i386/intelmic-mkoffload.c suggests a lack of > c

GOMP_offload_register

2015-07-13 Thread Nathan Sidwell
Ilya, GOMP_offload_register's target data argument is 'void *'. Is there any reason it shouldn't be 'const void *'? It would seem to me that that would be better? (a cursory look at i386/intelmic-mkoffload.c suggests a lack of consts in the variable decls there. ptx suffers the same problem